Skip to content
This repository has been archived by the owner on Jan 17, 2024. It is now read-only.

Revert "Common C integer types (#128)" #141

Merged
merged 2 commits into from
May 13, 2022
Merged

Revert "Common C integer types (#128)" #141

merged 2 commits into from
May 13, 2022

Conversation

dcharkes
Copy link
Contributor

This reverts commit 5e801e8.

By bumping the version number we can let pub get automatically upgrade from the 1.2.0 dev release. We had already retracted 1.2.0 stable, but we don't want to retract the dev release because ffigen dev releases depend on it.

Also, this cleans up the main branch of the repo to reflect the latest stable release of the package.

Copy link

@liamappelbe liamappelbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So iiuc, this change means that package:ffi supports SDK versions down to 2.12.0, but if the user wants the ABI specific types, they have to use version 2.17.0 or higher? Maybe we should mention that in the readme or something?

CHANGELOG.md Outdated Show resolved Hide resolved
@dcharkes dcharkes requested a review from liamappelbe May 12, 2022 17:50
@dcharkes
Copy link
Contributor Author

So iiuc, this change means that package:ffi supports SDK versions down to 2.12.0, but if the user wants the ABI specific types, they have to use version 2.17.0 or higher? Maybe we should mention that in the readme or something?

There are no ABI-specific types in this package at all. Unless they were using the dev release, they won't have ever seen them. Maybe adding it to the readme will add more confusion than clarification for people.

@dcharkes
Copy link
Contributor Author

The base branch restricts merging to authorized users.

cc @mit-mit

@dcharkes dcharkes merged commit fea40a9 into master May 13, 2022
@devoncarew devoncarew deleted the revert-c-types branch May 9, 2023 02:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants