This repository has been archived by the owner on Jan 28, 2024. It is now read-only.
Removed config dart-bool and target Bool / bool
#391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ool` and `ffi.Bool` as it's Dart and C Type respectively.
mannprerak2
changed the title
dart-booldart-bool and target Bool / bool
I think that's fine. There's no reason to artificially try to keep the major version number low. And this way we keep the contract that we don't break people if they don't update the major version. 👍 |
dcharkes
approved these changes
May 30, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dart-lang/native#310
Booleans are now always generated with
boolandffi.Boolas it's Dart and C Type respectively.I am not sure if this is worth upgrading the version to
6.0.0, but it's technically a breaking change for people usingdart-boolconfig.Here are some options I could think of -
5.1.0and throw an error ifdart-boolis passed asfalse.It's possible we could support this config up until 6.0.0, but it required making quite a few code changes which I feel aren't really worth adding just to be removed later.