Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target Bool / bool instead of wrapping as integers #310

Closed
dcharkes opened this issue Apr 12, 2022 · 1 comment · Fixed by dart-archive/ffigen#391
Closed

Target Bool / bool instead of wrapping as integers #310

dcharkes opened this issue Apr 12, 2022 · 1 comment · Fixed by dart-archive/ffigen#391
Labels
package:ffigen

Comments

@dcharkes
Copy link
Collaborator

dart:ffi has support for booleans since https://dart-review.googlesource.com/c/sdk/+/216900

We should generate that instead of != 0 with integers.

Context: dart-archive/ffigen#311 (comment)

cc @mannprerak2, seems I forgot about adding this to dart:ffi 😄
@mannprerak2
Copy link
Contributor

Cool, do we also remove the dart-bool config option then?

@mannprerak2 mannprerak2 mentioned this issue May 28, 2022
Merged
@dcharkes dcharkes mentioned this issue May 17, 2023
Closed
@liamappelbe liamappelbe transferred this issue from dart-archive/ffigen Nov 15, 2023
HosseinYousefi pushed a commit that referenced this issue Nov 16, 2023
@dependabot
[jnigen] Bump coverallsapp/github-action from 2.1.2 to 2.2.0 (#310)
f8fdfb1 
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.1.2 to 2.2.0.
- [Release notes](https://github.com/coverallsapp/github-action/releases)
- [Commits](coverallsapp/github-action@f350da2...c7885c0)

---
updated-dependencies:
- dependency-name: coverallsapp/github-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
HosseinYousefi pushed a commit that referenced this issue Nov 16, 2023
@dependabot
[jnigen] Bump coverallsapp/github-action from 2.1.2 to 2.2.0 (#310)
1f17bfa 
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.1.2 to 2.2.0.
- [Release notes](https://github.com/coverallsapp/github-action/releases)
- [Commits](coverallsapp/github-action@f350da2...c7885c0)

---
updated-dependencies:
- dependency-name: coverallsapp/github-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
parlough pushed a commit to parlough/native that referenced this issue Apr 8, 2024
@liamappelbe
[ffigen] NSString <-> String converters (dart-lang#310)
eece4af 
* NSString utils

* Add an extension method to String
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:ffigen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed config dart-bool and target Bool / bool mannprerak2/ffigen
3 participants
@dcharkes @liamappelbe @mannprerak2