Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage co19 and co19_2 failing tests #1094

Closed
sgrekhov opened this issue Jun 2, 2021 · 4 comments
Closed

Triage co19 and co19_2 failing tests #1094

sgrekhov opened this issue Jun 2, 2021 · 4 comments
Assignees

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Jun 2, 2021

Now we have ~60 failing co19 tests and more than 370 failing co19_2 tests. Need to triage the failures to check if all of them have issue numbers. I suspect that many of co19_2 failures caused by wrong test

iarkh added a commit that referenced this issue Jun 28, 2021
iarkh added a commit that referenced this issue Jun 28, 2021
…ng Iuuse tags added,test corrected (Language/Generics).
iarkh added a commit that referenced this issue Jul 1, 2021
iarkh added a commit that referenced this issue Jul 22, 2021
iarkh added a commit that referenced this issue Jul 22, 2021
iarkh added a commit that referenced this issue Jul 29, 2021
iarkh added a commit that referenced this issue Jul 29, 2021
…rectory, LibTests/io/File, LibTests/io/FileStat folder.
iarkh added a commit that referenced this issue Jul 29, 2021
…sts: FileSystemModifyEvent, HttpClient, HttpClientBasicCredentials, HttpClientDigestCredentials, HttpClientRequest, HttpClientResponse, HttpServer, IOSink.
iarkh added a commit that referenced this issue Aug 9, 2021
iarkh added a commit that referenced this issue Aug 9, 2021
iarkh added a commit that referenced this issue Aug 9, 2021
iarkh added a commit that referenced this issue Aug 9, 2021
iarkh added a commit that referenced this issue Aug 10, 2021
iarkh added a commit that referenced this issue Aug 10, 2021
iarkh added a commit that referenced this issue Aug 10, 2021
iarkh added a commit that referenced this issue Nov 3, 2021
- collection/LinkedHashSet, convert/JSOnCodec, core/Duration, core/Uri, core/UriData: updated according to master changes
- collection/ListBase, core/StackOverflowError: missing Issue tag added
- core/DataTime, core/RegExp: error diagnostic improved
- core/double: additional checks for JS runs added
iarkh added a commit that referenced this issue Nov 9, 2021
… corrected according to the Issue 27920 evaluation and current behavior.
iarkh added a commit that referenced this issue Nov 9, 2021
… corrected according to the Issue 27920 evaluation and current behavior.
iarkh added a commit that referenced this issue Nov 10, 2021
…or change for LibTest/core/RangeError/CheckNotNegative_A01_t02
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 11, 2021
2021-11-09 [email protected] More fix for dart-lang/co19#1094: co19_2 LibTest/collection/DoubleLinkedQueue tests corrected according to the Issue 27920 evaluation and current behavior.
2021-11-03 [email protected] More fix for dart-lang/co19#1094: co19_2 LibTest tests update: - collection/LinkedHashSet, convert/JSOnCodec, core/Duration, core/Uri, core/UriData: updated according to master changes - collection/ListBase, core/StackOverflowError: missing Issue tag added - core/DataTime, core/RegExp: error diagnostic improved - core/double: additional checks for JS runs added
2021-11-03 [email protected] More fix for dart-lang/co19#1094: Two LanguageFeatures/Constant-update-2018 tests updated according to the Dart 2.9 behavior.
2021-11-02 [email protected] More fix for dart-lang/co19#1094: LibTest/async tests updated according to the recent changes in master.
2021-11-02 [email protected] More fix for dart-lang/co19#1094: LibTest/async/Future/then_A05_t03 updated according to the recent changes in master.
2021-11-02 [email protected] More fix for dart-lang/co19#1094: Missing Issue tags added to LanguageFeatures/SimpleBounds tests, LanguageFeatures/Super-mixins/mixin_member_to6 updated to run correctly with dart2js.
2021-11-02 [email protected] More fix for dart-lang/co19#1094: LanguageFeatures/Extension-methods tests updated according to the recent changes in master.
2021-11-02 [email protected] More fix for dart-lang/co19#1094: Two LanguageFeatures/Constant-update-2018 tests updated according to the changes in master.

Change-Id: I4caf7a5603e836e96121341a2b4846982eb6a5bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220004
Reviewed-by: William Hesse <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 11, 2021
2021-11-11 [email protected] dart-lang/co19#1231. More Super parameters tests added
2021-11-10 [email protected] More fix for dart-lang/co19#1094: Missing Issue tags added to LibTest/io tests, minor change for LibTest/core/RangeError/CheckNotNegative_A01_t02
2021-11-10 [email protected] dart-lang/co19#1231. More Super parameters tests added
2021-11-09 [email protected] More fix for dart-lang/co19#1094: co19_2 LibTest/collection/DoubleLinkedQueue tests corrected according to the Issue 27920 evaluation and current behavior.
2021-11-09 [email protected] dart-lang/co19#1231. More Super parameters tests added
2021-11-08 [email protected] dart-lang/co19#1231. Super parameters type inference tests added
2021-11-02 [email protected] Fix tests on Mac OS X. (dart-lang/co19#1233)
2021-11-03 [email protected] dart-lang/co19#1231. More Super parameters tests added
2021-11-02 [email protected] More fix for dart-lang/co19#1094: Missing Issue tags added to LibTest/async tests.
2021-11-02 [email protected] More fix for dart-lang/co19#1094: LanguageFeatures/nnbd tests updated according to the recent dart behaviour, missing Issdue tags added.
2021-11-02 [email protected] More fix for dart-lang/co19#1109: Test LibraryFeatures/nnbd/Least-greatest-closure/typedef/typedef_dynamic_t22 removed according to the issue evaluation, static exception is thrown.
2021-11-02 [email protected] More fix for dart-lang/co19#1094: Test expectation updated for LanguageFeatures/Set-literals/constant_set_literals_A01_t01 test.
2021-11-02 [email protected] Fixes dart-lang/co19#1232. Expect FileStat.type to return underlying object for non-Windows OS's
2021-11-01 [email protected] dart-lang/co19#1231. More super parameters tests added
2021-10-29 [email protected] dart-lang/co19#1231. The first bunch of super parameters tests added
2021-10-28 [email protected] Fixes dart-lang/co19#1228. More named arguments anywhere constructors tests added
2021-10-27 [email protected] dart-lang/co19#1228. More named arguments anywhere tests added
2021-10-26 [email protected] dart-lang/co19#1228. Named arguments anywhere tests added

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: Ie70e28bc259aa9bacc3512866e92a2768e456271
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220003
Reviewed-by: William Hesse <[email protected]>
iarkh added a commit that referenced this issue Nov 12, 2021
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 23, 2021
2021-11-12 [email protected] More fix for dart-lang/co19#1094: Missing Issue tags added to the tests, LibTest/io/WebSocket tests updated.

Change-Id: I70e541cf9e7dafb0d0150dfd2f23534445ce4796
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220962
Reviewed-by: William Hesse <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
iarkh added a commit that referenced this issue Nov 24, 2021
iarkh added a commit that referenced this issue Nov 24, 2021
iarkh added a commit that referenced this issue Nov 24, 2021
…r moved to pre-nnbd, missung Issue tags added, comments added.
iarkh added a commit that referenced this issue Nov 24, 2021
iarkh added a commit that referenced this issue Nov 24, 2021
iarkh added a commit that referenced this issue Nov 25, 2021
…inal_t06.dart updated, Language/Variables/Evaluation_of_Implicit_Variable_Getters comments updated, missing Issue tags added.
iarkh added a commit that referenced this issue Nov 29, 2021
…inal_t06 test corrected according to the current dart 2.9 behavior.
iarkh added a commit that referenced this issue Dec 1, 2021
…it code for precompiled runtime should be 255
iarkh added a commit that referenced this issue Dec 6, 2021
…nguage/Libraries_and_Scripts/Scripts, LibTest/io/Process tests corrected.
iarkh added a commit that referenced this issue Dec 6, 2021
…nguage/Libraries_and_Scripts/Scripts, LibTest/io/Process tests corrected.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 7, 2021
2021-11-29 [email protected] dart-lang/co19#932. HttpRequest/responseText_A01_t02 test fixed
2021-11-26 [email protected] Fixes dart-lang/co19#1231. More Super parameters tests added
2021-11-25 [email protected] dart-lang/co19#1238. FFI tests fixed and issue numbers added
2021-11-24 [email protected] Merge branch 'master' of https://github.com/dart-lang/co19
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Link tests updated: comments added.
2021-11-24 [email protected] dart-lang/co19#1231. Super parameters tests fixed and new ones added
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Process/killPid_* tests updated.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTestCopyrights updated in LibTest/io/Process test.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Process tests updated to check process exit code correctly, new test added.

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I9f878f3400324fc44215350fa715e2e258cfd8bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221466
Reviewed-by: William Hesse <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 7, 2021
2021-12-07 [email protected] dart-lang/co19#932. HttpRequestUpload tests fixed
2021-12-06 [email protected] Issue dart-lang/co19#1094: Runtime executable mode checks moved to Utils/Expect, Language/Libraries_and_Scripts/Scripts, LibTest/io/Process tests corrected.
2021-12-03 [email protected] Issue dart-lang/co19#1239: in LibTest/io/Process/run_A01_t03 isDartkp is a getter now.
2021-12-03 [email protected] Subtype test added testing 500 elements deep transitivity
2021-12-02 [email protected] Issue dart-lang/co19#1239: typo corrected in LibTest/io/Process/run_A01_t03
2021-12-02 [email protected] Fixes dart-lang/co19#1241. Missed return statements added
2021-12-02 [email protected] Fixes dart-lang/co19#1240. Typos fixed in Named arguments anywhere tests
2021-12-01 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Process/run_A01_t03 test corrected: exit code for precompiled runtime should be 255

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I96860dcd3b42d56d2a0c202e1e5fbc251b92106a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222202
Reviewed-by: William Hesse <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jan 13, 2022
2022-01-12 [email protected] dart-lang/co19#1259. Roll failures fixed
2022-01-12 [email protected] dart-lang/co19#1258. Enhanced Enums semantics tests rewritten according to changed spec
2022-01-12 [email protected] Fixes dart-lang/co19#1261. Expected result value fixed
2022-01-11 [email protected] dart-lang/co19#1259. Different roll failures fixed (mainly typos)
2022-01-11 [email protected] Fixes dart-lang/co19#1247. Allow positional parameters with the different name than in superclass
2022-01-10 [email protected] Fixes dart-lang/co19#1248. Add additional error expectation
2022-01-10 [email protected] Fixes dart-lang/co19#1256. Use correct type of super parameters. Expect an error if the type is wrong
2022-01-10 [email protected] Fixes dart-lang/co19#1255. Use nullable type parameter for type check
2022-01-10 [email protected] Fixes dart-lang/co19#1254. Typo fixed
2022-01-10 [email protected] Fixes dart-lang/co19#1253. Typo fixed
2022-01-10 [email protected] Fixes dart-lang/co19#1252. Typo fixed
2022-01-10 [email protected] Fixes dart-lang/co19#1251. Default value is added to non-nullable optional argument
2022-01-10 [email protected] Fixes dart-lang/co19#1250. Named parameter made named in a constructor call
2022-01-10 [email protected] Fixes dart-lang/co19#1249. Missed superconstructor added
2022-01-10 [email protected] Fixes dart-lang/co19#1246. Use correct type for type inference
2021-12-28 [email protected] Avoid sender making more progress than the receiver in Isolate/pause_A01_t01/2. (dart-lang/co19#1242)
2021-12-28 [email protected] Fixes dart-lang/co19#1243. Runtime type checks added to typed_data tests
2021-12-27 [email protected] dart-lang/co19#1243 Runtime type checks added to io and match tests
2021-12-24 [email protected] dart-lang/co19#1243 Runtime type checks added
2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks added to Spread collections tests
2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks moved to Expect class
2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks added to Set literals tests
2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks added to Expect class
2021-12-22 [email protected] dart-lang/co19#1243 Runtime type checks added for nnbd tests
2021-12-22 [email protected] dart-lang/co19#1244 CHECK_TOP_MERGE replaced by CheckTopMerge
2021-12-22 [email protected] dart-lang/co19#1243 Runtime type checks added for nnbd tests
2021-12-21 [email protected] Fixes dart-lang/co19#1245. Fix checking type of Enum members
2021-12-20 [email protected] dart-lang/co19#1243 Runtime type checks added for Control flow collections, Constructor tear-offs and Generic functions as type arguments
2021-12-17 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false'
2021-12-16 [email protected] Issue dart-lang/co19#1244: Utils functions updated according to the Effective Dart Guide, relative tests updated accordingly.
2021-12-16 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false'
2021-12-15 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false'
2021-12-15 [email protected] dart-lang/co19#1243 Expect.isTrue() is returned back for type checking
2021-12-14 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false'
2021-12-13 [email protected] Issue dart-lang/co19#1094: minor improvement for Utils/test_mode_check
2021-12-13 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false'

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I8b2b346600c03061b8b735be874c3f377d70b354
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227800
Reviewed-by: William Hesse <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Mar 28, 2022
2022-03-23 [email protected] Replace InternetAddressType.ANY with InternetAddressType.any (dart-lang/co19#1326)
2022-02-21 [email protected] dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed
2022-02-11 [email protected] Fixes dart-lang/co19#1300: Corrected tests according to the recent changes in CFE.
2022-01-31 [email protected] dart-lang/co19#1281. Expected error location updated
2021-12-13 [email protected] Issue dart-lang/co19#1094: minor improvement for Utils/test_mode_check
2021-12-06 [email protected] Issue dart-lang/co19#1094: Runtime executable mode checks moved to Utils/Expect, Language/Libraries_and_Scripts/Scripts, LibTest/io/Process tests corrected.
2021-11-29 [email protected] More fix for dart-lang/co19#1094: Language/Reference/Lexical_Rules/Reserved_Words/final_t06 test corrected according to the current dart 2.9 behavior.
2021-11-25 [email protected] More fix for dart-lang/co19#1094: Language/Reference/Lexical_Rules/Reserved_Words/final_t06.dart updated, Language/Variables/Evaluation_of_Implicit_Variable_Getters comments updated, missing Issue tags added.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/typed_data tests updated according to the changes in master.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Link test updated: changes from master moved to pre-nnbd.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Link tests updated: changes from master moved to pre-nnbd, missung Issue tags added, comments added.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Process/killPid_* tests updated.
2021-11-24 [email protected] More fix for dart-lang/co19#1094: LibTest/io/Process tests updated to check process exit code correctly, new test added.

Change-Id: I2f2a857d71b17b568534921ae7edfb517290d9ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239064
Reviewed-by: William Hesse <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants