Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

co19/LanguageFeatures/Super-parameters/semantics_A01_t02 #1248

Closed
scheglov opened this issue Jan 5, 2022 · 0 comments
Closed

co19/LanguageFeatures/Super-parameters/semantics_A01_t02 #1248

scheglov opened this issue Jan 5, 2022 · 0 comments
Assignees
@sgrekhov

Comments

@scheglov
Copy link

scheglov commented Jan 5, 2022

It does not actually test declaring super.p outside a constructor, it is just a syntactic error.

FAILED: dart2analyzer-none release_x64 co19/LanguageFeatures/Super-parameters/semantics_A01_t02
Expected: Pass
Actual: MissingCompileTimeError

--- Command "dart2analyzer" (took 15.000795s):
DART_CONFIGURATION=ReleaseX64 sdk/bin/dartanalyzer --enable-experiment=super-parameters --ignore-unrecognized-flags --packages=/Users/scheglov/Source/Dart/sdk.git/sdk/.packages --format=json --no-hints /Users/scheglov/Source/Dart/sdk.git/sdk/tests/co19/src/LanguageFeatures/Super-parameters/semantics_A01_t02.dart

static error failures:
- Unexpected error at line 31, column 3, length 1: COMPILE_TIME_ERROR.NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD

- Unexpected error at line 31, column 17, length 2: COMPILE_TIME_ERROR.SUPER_FORMAL_PARAMETER_WITHOUT_ASSOCIATED_POSITIONAL

--- Re-run this test:
python3 tools/test.py -m release -c dart2analyzer co19/LanguageFeatures/Super-parameters/semantics_A01_t02
@sgrekhov sgrekhov self-assigned this Jan 10, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jan 13, 2022
@athomas
[co19] Roll co19 to 143ad7f74919b132951e447a547236e991d9f900
6051eff 
2022-01-12 [email protected] dart-lang/co19#1259. Roll failures fixed
2022-01-12 [email protected] dart-lang/co19#1258. Enhanced Enums semantics tests rewritten according to changed spec
2022-01-12 [email protected] Fixes dart-lang/co19#1261. Expected result value fixed
2022-01-11 [email protected] dart-lang/co19#1259. Different roll failures fixed (mainly typos)
2022-01-11 [email protected] Fixes dart-lang/co19#1247. Allow positional parameters with the different name than in superclass
2022-01-10 [email protected] Fixes dart-lang/co19#1248. Add additional error expectation
2022-01-10 [email protected] Fixes dart-lang/co19#1256. Use correct type of super parameters. Expect an error if the type is wrong
2022-01-10 [email protected] Fixes dart-lang/co19#1255. Use nullable type parameter for type check
2022-01-10 [email protected] Fixes dart-lang/co19#1254. Typo fixed
2022-01-10 [email protected] Fixes dart-lang/co19#1253. Typo fixed
2022-01-10 [email protected] Fixes dart-lang/co19#1252. Typo fixed
2022-01-10 [email protected] Fixes dart-lang/co19#1251. Default value is added to non-nullable optional argument
2022-01-10 [email protected] Fixes dart-lang/co19#1250. Named parameter made named in a constructor call
2022-01-10 [email protected] Fixes dart-lang/co19#1249. Missed superconstructor added
2022-01-10 [email protected] Fixes dart-lang/co19#1246. Use correct type for type inference
2021-12-28 [email protected] Avoid sender making more progress than the receiver in Isolate/pause_A01_t01/2. (dart-lang/co19#1242)
2021-12-28 [email protected] Fixes dart-lang/co19#1243. Runtime type checks added to typed_data tests
2021-12-27 [email protected] dart-lang/co19#1243 Runtime type checks added to io and match tests
2021-12-24 [email protected] dart-lang/co19#1243 Runtime type checks added
2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks added to Spread collections tests
2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks moved to Expect class
2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks added to Set literals tests
2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks added to Expect class
2021-12-22 [email protected] dart-lang/co19#1243 Runtime type checks added for nnbd tests
2021-12-22 [email protected] dart-lang/co19#1244 CHECK_TOP_MERGE replaced by CheckTopMerge
2021-12-22 [email protected] dart-lang/co19#1243 Runtime type checks added for nnbd tests
2021-12-21 [email protected] Fixes dart-lang/co19#1245. Fix checking type of Enum members
2021-12-20 [email protected] dart-lang/co19#1243 Runtime type checks added for Control flow collections, Constructor tear-offs and Generic functions as type arguments
2021-12-17 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false'
2021-12-16 [email protected] Issue dart-lang/co19#1244: Utils functions updated according to the Effective Dart Guide, relative tests updated accordingly.
2021-12-16 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false'
2021-12-15 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false'
2021-12-15 [email protected] dart-lang/co19#1243 Expect.isTrue() is returned back for type checking
2021-12-14 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false'
2021-12-13 [email protected] Issue dart-lang/co19#1094: minor improvement for Utils/test_mode_check
2021-12-13 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false'

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I8b2b346600c03061b8b735be874c3f377d70b354
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227800
Reviewed-by: William Hesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scheglov @sgrekhov