Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [co19] Roll co19 to cd6510c8346444792b37f6f26feffcc234a44dd1 #1223

Closed
athomas opened this issue Oct 14, 2021 · 3 comments
Closed

Failures on [co19] Roll co19 to cd6510c8346444792b37f6f26feffcc234a44dd1 #1223

athomas opened this issue Oct 14, 2021 · 3 comments

Comments

@athomas
Copy link
Member

athomas commented Oct 14, 2021

There are new test failures on [co19] Roll co19 to cd6510c8346444792b37f6f26feffcc234a44dd1.

The tests

co19/LanguageFeatures/Constructor-tear-offs/expression_A04_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/Constructor-tear-offs/tearing_off_from_typedef_A03_t07 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/constructor_call_A01_t01 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/constructor_call_A01_t02 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/constructor_call_A02_t01 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/constructor_call_A02_t02 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t01 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t02 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t03 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t04 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t05 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t05 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A02_t01 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A02_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A02_t02 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A02_t02 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A02_t03 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t01 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t02 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t02 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t03 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t03 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t04 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A04_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A04_t01 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A04_t02 CompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A04_t02 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A04_t03 CompileTimeError (expected Pass)
    and 16 more tests

are failing on configurations

analyzer-asserts-strong-linux
analyzer-asserts-weak-linux
cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-strong-linux-x64-chrome
dart2js-hostasserts-weak-linux-x64-chrome
dartdevk-strong-linux-release-chrome
dartdevk-weak-linux-release-chrome
dartk-strong-linux-debug-x64
dartk-strong-linux-release-x64
dartk-weak-asserts-linux-debug-x64
dartk-weak-asserts-linux-release-x64
dartkp-strong-linux-release-x64
dartkp-weak-asserts-linux-release-x64
@eernstg
Copy link
Member

eernstg commented Oct 14, 2021

Note #1224, which could presumably cause some of these failures.

@athomas
Copy link
Member Author

athomas commented Oct 14, 2021

One more that showed up post-submit:
cfe-strong-linux
Pass -> Crash (expected Pass)
✔ co19/LanguageFeatures/Abstract-external-fields/static_analysis_abstract_A06_t02

sgrekhov pushed a commit that referenced this issue Oct 14, 2021
#1223. Equality of extension tear-offs is not specified
4667db6
@sgrekhov
Copy link
Contributor

Triaged. @athomas @eernstg may be to turn off Enhanced Enums tests for now (I'll do it if so)?

analyzer...cfe...  
new test -> Crash (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/constructor_call_A01_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/constructor_call_A01_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/constructor_call_A02_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/constructor_call_A02_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t03 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t04 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t05 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A02_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A02_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A02_t03 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t03 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t04 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A04_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A04_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A04_t03 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A05_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A05_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A05_t03 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A01_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A01_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A01_t03 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A02_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A02_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A02_t03 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A02_t04 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A02_t05 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A02_t06 Enhanced enums feature is not implemented yet
analyzer...dart2js...dartdevk...  
Pass -> CompileTimeError (expected Pass)  
✔ co19/LanguageFeatures/Constructor-tear-offs/tearing_off_from_typedef_A03_t07 dart-lang/sdk#47267
dart2js...dartdevk...dartk...  
CompileTimeError -> RuntimeError (expected Pass)  
✔ co19/LanguageFeatures/Constructor-tear-offs/expression_A04_t03 Fixed
dart2js...dartdevk...dartk...dartkp...  
new test -> CompileTimeError (expected Pass)  
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t05 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A02_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A02_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A03_t03 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A04_t01 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A04_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A04_t03 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/grammar_A05_t03 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A01_t02 Enhanced enums feature is not implemented yet
✔ co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A01_t03 Enhanced enums feature is not implemented yet
cfe-strong-linux  
Pass -> Crash (expected Pass)  
✔ co19/LanguageFeatures/Abstract-external-fields/static_analysis_abstract_A06_t02 Not reproducible on the edge version of SDK

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 26, 2021
@athomas
[co19] Roll co19 to 73545b2bf6c7f8e4eb931bb04d86e38d6485deee
c3e3192 
2021-10-25 [email protected] dart-lang/co19#1207. More Enhanced enums tests added
2021-10-25 [email protected] dart-lang/co19#1207. More Enhanced enums semantics tests added
2021-10-21 [email protected] dart-lang/co19#1207. More Enhanced enums semantics tests added
2021-10-20 [email protected] dart-lang/co19#1207. Enhanced enums semantics tests fixed and new added
2021-10-20 [email protected] dart-lang/co19#1207. Enhanced enums semsntics tests added
2021-10-20 [email protected] Fix typo (dart-lang/co19#1227)
2021-10-19 [email protected] dart-lang/co19#1207. More enhanced enums tests added
2021-10-19 [email protected] More fix for dart-lang/co19#1094: Missing Issue tag added (47496).
2021-10-19 [email protected] More fix for dart-lang/co19#1094: Test updated.
2021-10-18 [email protected] dart-lang/co19#1207. More enhanced enums tests added
2021-10-18 [email protected] More fix for dart-lang/co19#1094: Test updated to expect current dart behavior, Issue tag added.
2021-10-15 [email protected] Fixes dart-lang/co19#1225. Remove check for identity of 0/0 and nan
2021-10-15 [email protected] dart-lang/co19#1207. More Enhanced Enums tests added
2021-10-14 [email protected] dart-lang/co19#1223. Equality of extension tear-offs is not specified
2021-10-14 [email protected] Fixes dart-lang/co19#1224. Don't expect not identical tear-offs to be identical

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I63a11f54c383ca8d90bbdea97bcf65c9ca9e436d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218120
Reviewed-by: William Hesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgrekhov @eernstg @athomas