Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [co19] Roll co19 to 7c4a94f408bfba153265ce2bba25bfda1a6c4329 #2034

Closed
athomas opened this issue May 4, 2023 · 1 comment
Closed

Failures on [co19] Roll co19 to 7c4a94f408bfba153265ce2bba25bfda1a6c4329 #2034

athomas opened this issue May 4, 2023 · 1 comment
Assignees
@sgrekhov

Comments

@athomas
Copy link
Member

athomas commented May 4, 2023

There are new test failures on [co19] Roll co19 to 7c4a94f408bfba153265ce2bba25bfda1a6c4329.

The tests

co19/LanguageFeatures/Class-modifiers/versioning_A01_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Class-modifiers/versioning_A02_t04 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Class-modifiers/versioning_A03_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Class-modifiers/versioning_A03_t02 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Class-modifiers/versioning_A03_t04 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Patterns/execution_pattern_await_for_in_statement_A02_t03 CompileTimeError (expected Pass)

are failing on configurations

analyzer-asserts-linux
cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-linux-chrome-unsound
dart2js-hostasserts-linux-d8
dart2js-linux-chrome
dart2wasm-hostasserts-linux-x64-d8
ddc-linux-chrome
ddc-linux-chrome-unsound
vm-mac-debug-arm64
vm-mac-release-arm64
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 4, 2023
@sgrekhov
Fixes dart-lang#2034. Fix roll failures, add issues numbers
050b31a
@sgrekhov
Copy link
Contributor

sgrekhov commented May 4, 2023

co19/LanguageFeatures/Class-modifiers/versioning_A01_t01 fixed by #2035
co19/LanguageFeatures/Class-modifiers/versioning_A02_t04 dart-lang/sdk#52259
co19/LanguageFeatures/Class-modifiers/versioning_A03_t01 dart-lang/sdk#52078
co19/LanguageFeatures/Class-modifiers/versioning_A03_t02 dart-lang/sdk#52078
co19/LanguageFeatures/Class-modifiers/versioning_A03_t04 dart-lang/sdk#52078
co19/LanguageFeatures/Patterns/execution_pattern_await_for_in_statement_A02_t03 fixed by #2035

@eernstg eernstg closed this as completed in 794313d May 4, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 4, 2023
@sgrekhov @athomas
[co19] Roll co19 to 794313da70f2b8c1150ffcbf2fbf8746649ab09f
6d90390 
2023-05-04 [email protected] Fixes dart-lang/co19#2034. Fix roll failures, add issues numbers (dart-lang/co19#2035)
2023-05-03 [email protected] dart-lang/co19#1401. Async for-in tests for patterns (dart-lang/co19#2032)
2023-04-28 [email protected] dart-lang/co19#1959. Grammar tests added (dart-lang/co19#2031)
2023-04-28 [email protected] dart-lang/co19#1959. Versioning tests added (dart-lang/co19#2029)

Change-Id: Ic29913ebd7260c4069e6baa27a797219ce12d956
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/301440
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @athomas