Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Class modifiers] No error in CFE when class from a pre-feature library mixes in base mixin #52259

Closed
sgrekhov opened this issue May 4, 2023 · 2 comments
Assignees
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented May 4, 2023

Test co19/LanguageFeatures/Class-modifiers/versioning_A02_t04 fails on CFE when class from a pre-feature library mixes in base mixin from a post-feature. All expected errors below are missed in CFE (but reported analyzer)

// class_modifiers_lib.dart
// @dart=3.0
base mixin class BaseMixinClass {}
abstract base mixin class AbstractBaseMixinClass {}
base mixin BaseMixin {}

// versioning_A02_t04.dart
// @dart=2.19

import "class_modifiers_lib.dart";

class WithBaseMixinClass with BaseMixinClass {}
//    ^^^^^^^^^^^^^^^^^^
// [analyzer] unspecified
// [cfe] unspecified

class WithAbstractBaseMixinClass with AbstractBaseMixinClass {}
//    ^^^^^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] unspecified
// [cfe] unspecified

class WithBaseMixin with BaseMixin {}
//    ^^^^^^^^^^^^^
// [analyzer] unspecified
// [cfe] unspecified

abstract class AbstractWithBaseMixinClass with BaseMixinClass {}
//             ^^^^^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] unspecified
// [cfe] unspecified

abstract class AbstractWithAbstractBaseMixinClass with AbstractBaseMixinClass {}
//             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] unspecified
// [cfe] unspecified

abstract class AbstractWithBaseMixin with BaseMixin {}
//             ^^^^^^^^^^^^^^^^^^^^^
// [analyzer] unspecified
// [cfe] unspecified
@sgrekhov sgrekhov added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label May 4, 2023
@kallentu
Copy link
Member

@sgrekhov This should also be fixed now with the fix from #52316

@sgrekhov
Copy link
Contributor Author

Confirmed. Fixed. Thanx!

copybara-service bot pushed a commit that referenced this issue May 11, 2023
…ctions.

Just adding a few tests to make sure there's no regressions.

Bug: #52259
Change-Id: I6aad2d0040736462117a0ce60e3001725923e242
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302445
Commit-Queue: Kallen Tu <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.
Projects
None yet
Development

No branches or pull requests

2 participants