-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor doc generation #4106
refactor doc generation #4106
Conversation
@parlough - the dart.dev site now includes lint codes? Just codes+docs for stable lints? |
Yep, dart.dev includes linter rules, their descriptions, status, and version support at https://dart.dev/tools/linter-rules. This includes both stable and experimental or unreleased rules. The format isn't amazing as there are plans for a new structure with some consolidation with diagnostic messages, so I decided to focus on that instead. It seems the current thinking is to split linter documentation by two separate use cases (on dart.dev):
Some extra context on this idea: dart-lang/site-www#4498, dart-lang/site-www#4499 I'd be happy to discuss more and create a formal plan if it's the direction we want to go. It's my intended focus after finishing some flutter.dev work :) |
Thanks for the info! I see from one of the linked issues that one of the goals is I think generated markdown files here still provide some value, but am not sure that I can really describe why. Perhaps the value is marginal enough to not be worth the maintenance cost. It looks like we have stable |
Yep, that's what the analysis server uses today for diagnostics. With the discussed changes this would be still be the intended access point for the original diagnostics, and now the new access point for lint diagnostics as well. One exists for lints as well ( |
I thought about updating the analysis server to link to the dart.dev linter rule docs rather than |
For what it's worth, I already have a significant number of the linter docs rewritten to use the same format as the analyzer diagnostic messages. |
I think it's a good idea to wait at least until we're feel like we've converged on a link format that feels stable. Maybe we should break out a separate issue for that? /fyi also @MaryaBelanger who's done some thinking about this all too. |
From the comments above, it sounds like the link format is |
Not necessarily. There's an ongoing discussion about moving all of the lint code documentation into https://dart.dev/tools/diagnostic-messages. The plans are still being discussed (temporarily on hold until the 3.0 work is done), so changes at this point are probably premature. |
Gotcha, makes sense to me. It sounds like doc simplification + consolidation here is already planned, and might even happen in the near term. I'll close this PR. |
This is currently a speculative refactor of the linter's doc generation.
This is generally in the spirit of #2301 (though I should probably open a more specific issue). The main motivation for me here is that the current linter docs (https://dart-lang.github.io/linter/lints/index.html) don't have either a dart.dev style or a github style; they have their own separate branding.
Some potential changes:
Some sample generated markdown files included w/ this PR.