-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.0.0 stable that targets ABI-specific types in Dart 2.17 #279
Comments
Now that Dart 2.17 is out, can we use the types from _Originally posted by @simolus3 in #530 @simolus3 can you make a PR if we remove the goldens from ObjectiveC? (edit: done) |
I can get a PR ready for using |
I've opened dart-archive/ffigen#365. Before 5.0.0 is released, perhaps version 1.2.0 of @dcharkes I can open a PR to replace the ABI-specific types from |
Can't we revert back to 1.1.2? 1.2.0 contained the ABI-specific types that we decided should be in Yes, the goal is to release a version of package:ffi without the ABI-specific types, but that is already out there 1.1.2. It is just confusing that we don't have a newer version released. |
I think the biggest missing feature from the ObjC support is that there's no memory management atm. We just leak all created objects. But I suppose that's ok for an experimental feature. |
@liamappelbe Would you like more disclaimers in the README and/or logs when using it? Or can I go ahead and release 5.0.0 ? |
I think the current disclaimers are good. You can release. |
https://pub.dev/packages/ffigen/versions/5.0.0 Thanks @liamappelbe @brianquinlan @simolus3 @mannprerak2 for your contributions! 🚀 |
We should release a new version of ffigen that targets the ABI-specific types in
dart:ffi
now that Dart 2.17 has been released.cc @mannprerak2 or @simolus3 can you make a PR for this?
dart:ffi
(and no longerpackage:ffi
at all?)@liamappelbe @brianquinlan ObjectiveC checklist
Super cool to have experimental ObjectiveC support in the next release! (Prepare for user bug reports! 🎉 )
Maybe we can make a release tonight or tomorrow.
The text was updated successfully, but these errors were encountered: