Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0.0 stable that targets ABI-specific types in Dart 2.17 #279

Closed
5 of 6 tasks
dcharkes opened this issue May 12, 2022 · 8 comments
Closed
5 of 6 tasks

Release 5.0.0 stable that targets ABI-specific types in Dart 2.17 #279

dcharkes opened this issue May 12, 2022 · 8 comments

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented May 12, 2022

We should release a new version of ffigen that targets the ABI-specific types in dart:ffi now that Dart 2.17 has been released.

cc @mannprerak2 or @simolus3 can you make a PR for this?

@liamappelbe @brianquinlan ObjectiveC checklist

  • Do we have documentation on the ObjectiveC features that they are (bold & caps) experimental and that they can change at any time. Both in the readme and as a severe log when using the feature?
  • Anything we should be aware of before making a 5.0.0 stable release?

Super cool to have experimental ObjectiveC support in the next release! (Prepare for user bug reports! 🎉 )

Maybe we can make a release tonight or tomorrow.

@dcharkes
Copy link
Collaborator Author

dcharkes commented May 12, 2022

Now that Dart 2.17 is out, can we use the types from dart:ffi directly? (I was trying to contribute a fix, but most of the generated libraries in test/ only generate correctly on a macOS libc so I'm out of luck)

_Originally posted by @simolus3 in #530

@simolus3 can you make a PR if we remove the goldens from ObjectiveC? (edit: done)

@simolus3
Copy link
Contributor

I can get a PR ready for using dart:ffi ABI-specific integer types and bumping the pubspec version later today if it helps.

@simolus3
Copy link
Contributor

I've opened dart-archive/ffigen#365. Before 5.0.0 is released, perhaps version 1.2.0 of package:ffi should be released as well (so that this package doesn't have to depend on a pre-release version of it).

@dcharkes I can open a PR to replace the ABI-specific types from package:ffi with typedefs pointing towards the new type in dart:ffi, but I wonder if it makes sense to just remove them from package:ffi entirely?

@dcharkes
Copy link
Collaborator Author

Can't we revert back to 1.1.2? 1.2.0 contained the ABI-specific types that we decided should be in dart:ffi instead.

Yes, the goal is to release a version of package:ffi without the ABI-specific types, but that is already out there 1.1.2. It is just confusing that we don't have a newer version released.

@liamappelbe
Copy link
Contributor

  • Anything we should be aware of before making a 5.0.0 stable release?

I think the biggest missing feature from the ObjC support is that there's no memory management atm. We just leak all created objects. But I suppose that's ok for an experimental feature.

@dcharkes
Copy link
Collaborator Author

  • Anything we should be aware of before making a 5.0.0 stable release?

I think the biggest missing feature from the ObjC support is that there's no memory management atm. We just leak all created objects. But I suppose that's ok for an experimental feature.

@liamappelbe Would you like more disclaimers in the README and/or logs when using it? Or can I go ahead and release 5.0.0 ?

@liamappelbe
Copy link
Contributor

I think the current disclaimers are good. You can release.

@dcharkes
Copy link
Collaborator Author

@liamappelbe liamappelbe transferred this issue from dart-archive/ffigen Nov 15, 2023
HosseinYousefi pushed a commit that referenced this issue Nov 16, 2023
* Use UTF-16 in strings
HosseinYousefi pushed a commit that referenced this issue Nov 16, 2023
* Use UTF-16 in strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants