Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate final initializes do not cause a compile error #1035

Closed
jtmcdole opened this issue Jan 3, 2012 · 10 comments
Closed

Duplicate final initializes do not cause a compile error #1035

jtmcdole opened this issue Jan 3, 2012 · 10 comments
Assignees
@peter-ahe-google
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Milestone
M1

Comments

@jtmcdole
Copy link
Contributor

jtmcdole commented Jan 3, 2012

New test, language/ConstructorDuplicateInitializersTest.dart:

class Class {
  Class(var v)
    : field_ = v
    , field_ = 2 /// 01: compile-time error
  ;
  Class.field(this.field_)
    : field_ = 2 /// 02: compile-time error
  ;
  final field_;
}

main() {
  new Class(42);
  new Class.field(42);
}

Similar to http://code.google.com/p/dart/issues/detail?id=1034
@anders-sandholm
Copy link
Contributor

Removed Area-Frog label.
Added Area-Dart2JS, FromAreaFrog labels.

@kasperl
Copy link

kasperl commented Jun 12, 2012

Another negative language test issue.

Set owner to @peter-ahe-google.
Removed FromAreaFrog label.
Added Accepted label.
Changed the title to: "Duplicate final initializes do not cause a compile error".

@peter-ahe-google
Copy link
Contributor

Added this to the M1 milestone.
Removed Priority-Medium label.
Added Priority-High label.

@peter-ahe-google
Copy link
Contributor

dart2js fails to reject subtest 02:

  Class.field(this.field_)
    : field_ = 2 /// 02: compile-time error
  ;

@johnniwinther
Copy link
Member

cc @peter-ahe-google.
Set owner to @johnniwinther.
Added Started label.

@johnniwinther
Copy link
Member

Has been fixed for a long time.

Added Fixed label.

@peter-ahe-google
Copy link
Contributor

This bug is not fixed, this is from dart/tests/language/language_dart2js.status:

constructor_duplicate_initializers_test/02: Fail, OK # Negative language test.

cc @johnniwinther.
Set owner to @peter-ahe-google.
Added Accepted label.

@DartBot
Copy link

DartBot commented Aug 15, 2012

This comment was originally written by @aam

Please, take a look at the following fix https://chromiumcodereview.appspot.com/10834327/

@peter-ahe-google
Copy link
Contributor

I'll commit the change on behalf of Alexander.

Added Started label.

@peter-ahe-google
Copy link
Contributor

Fixed in r10947.

Added Fixed label.

@jtmcdole jtmcdole added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js labels Aug 20, 2012
@jtmcdole jtmcdole added this to the M1 milestone Aug 20, 2012
dart-bot pushed a commit that referenced this issue Apr 7, 2021
@athomas
[co19] Roll co19 to 812ab751c41fe8d706fd1e4aae62d2dea2887ac2
4a6a92e 
2021-04-07 [email protected] Fixes #535: more nnbd tests for constant evaluation added.
2021-04-07 [email protected] Fixes #1068. Remove excessive - in a SharedOptions
2021-04-05 [email protected] Fixes #535: more nnbd tests for constant evaluation added.
2021-04-05 [email protected] Fixes #996: more tests added.
2021-04-05 [email protected] Fixes #996: more tests added.
2021-04-05 [email protected] Fixes #1067: added checks for old and new dart versions.
2021-04-05 [email protected] Fixes #1066: added @Dart=2.12 to the initial version of the test, new test which checks recent dart behavior added.
2021-04-05 [email protected] Fixes #1057: Expected result doe the tests with mailformed types updated.
2021-04-02 [email protected] Fixes #1062. Remove unnecessary assignment
2021-04-01 [email protected] Fixes #1057: Expected result doe the tests with mailformed types updated.
2021-04-01 [email protected] Expected error code is fixed for Windows
2021-04-01 [email protected] Fixes #1060. Expected error message position updated
2021-04-01 [email protected] Fixes #1059. Expected error message updated
2021-04-01 [email protected] Fixes #1024. Adjust expected results for web platforms
2021-04-01 [email protected] #993. More Array tests added
2021-03-31 [email protected] Update LICENSE
2021-03-31 [email protected] #993. Array tests added
2021-03-31 [email protected] Issue #1053: Missing Issue tag added, test expectation updated.
2021-03-30 [email protected] Fixes #1054: Updated expectations for mailformed raw type variables.
2021-03-30 [email protected] Fixes #1050: Updated expectations for mailformed raw type variables.
2021-03-30 [email protected] Fixes #1050: Got rid of mailformed row type variable usage in i-2-b- tests.
2021-03-29 [email protected] Fixes #1043. Remove static warning as an expected result
2021-03-29 [email protected] Fixes #1049: Correct expectation adjusted
2021-03-29 [email protected] Fixes #1048. Move tests to correct folder and change the description
2021-03-29 [email protected] Fixes #1046: Test adjusted to work with the generic metadata feature enabled.
2021-03-29 [email protected] Fixes #1047. Change expected result to not to fail on JavaScript configurations
2021-03-29 [email protected] Fixes #1044. Change expected result to not to fail on JavaScript configurations
2021-03-26 [email protected] Fixes #1029: Missing Issue tag added to the test.
2021-03-26 [email protected] Fixes #1042. Add check that produces different results for triple and double shifts
2021-03-26 [email protected] Fixes #1042. Fix built-in_types_t11.dart to expect correct results
2021-03-25 [email protected] Fixes #1019. Don't use type aliases in legacy libraries
2021-03-25 [email protected] Fixes #1039: Old-style aliases corrected.
2021-03-25 [email protected] Fixes #988. Expect static type warning in a right way
2021-03-24 [email protected] Issues #1029: Static expectation corrected.
2021-03-24 [email protected] Issues #1035: Issue tag for the bug 45443 added.
2021-03-24 [email protected] Merge branch 'master' of https://github.com/dart-lang/co19
2021-03-24 [email protected] #1023. Change SplayTreeMap and SplayTreeSet tests according to the new behavior
2021-03-23 [email protected] #1021. Remove expecting errors on web configurations for some negative numbers
2021-03-23 [email protected] Fixes #1034. Missed experimental flag added
2021-03-23 [email protected] #1033. Perform runtime check on big values for non-JavaScript configurations only
2021-03-23 [email protected] Issues #1029: co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02 corrected and does not expect a compile error now.

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I5fae01c7b48aba502da04638430f4f6de79ac745
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194241
Reviewed-by: William Hesse <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peter-ahe-google peter-ahe-google

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Milestone
M1
Development

No branches or pull requests
6 participants
@jtmcdole @kasperl @anders-sandholm @peter-ahe-google @DartBot @johnniwinther