Generalize parameters to Iterable where possible #1059
Labels
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
type-enhancement
A request for a change that isn't a bug
Comments
|
Removed Type-Defect label. |
|
Issue #6256 has been merged into this issue. |
|
See http://code.google.com/p/dart/issues/detail?id=5573 related to Future.wait |
|
All the mentioned methods have been addressed now, and have either been changed to Iterable, been removed, or in the case of Set.intersection changed to be more restricted (only takes a Set). Added Fixed label. |
DartBot
added
Type-Enhancement
area-core-library
This was referenced Jun 3, 2015
kevmoo
added
type-enhancement
dart-bot
pushed a commit
that referenced
this issue
Apr 7, 2021
2021-04-07 [email protected] Fixes #535: more nnbd tests for constant evaluation added. 2021-04-07 [email protected] Fixes #1068. Remove excessive - in a SharedOptions 2021-04-05 [email protected] Fixes #535: more nnbd tests for constant evaluation added. 2021-04-05 [email protected] Fixes #996: more tests added. 2021-04-05 [email protected] Fixes #996: more tests added. 2021-04-05 [email protected] Fixes #1067: added checks for old and new dart versions. 2021-04-05 [email protected] Fixes #1066: added @Dart=2.12 to the initial version of the test, new test which checks recent dart behavior added. 2021-04-05 [email protected] Fixes #1057: Expected result doe the tests with mailformed types updated. 2021-04-02 [email protected] Fixes #1062. Remove unnecessary assignment 2021-04-01 [email protected] Fixes #1057: Expected result doe the tests with mailformed types updated. 2021-04-01 [email protected] Expected error code is fixed for Windows 2021-04-01 [email protected] Fixes #1060. Expected error message position updated 2021-04-01 [email protected] Fixes #1059. Expected error message updated 2021-04-01 [email protected] Fixes #1024. Adjust expected results for web platforms 2021-04-01 [email protected] #993. More Array tests added 2021-03-31 [email protected] Update LICENSE 2021-03-31 [email protected] #993. Array tests added 2021-03-31 [email protected] Issue #1053: Missing Issue tag added, test expectation updated. 2021-03-30 [email protected] Fixes #1054: Updated expectations for mailformed raw type variables. 2021-03-30 [email protected] Fixes #1050: Updated expectations for mailformed raw type variables. 2021-03-30 [email protected] Fixes #1050: Got rid of mailformed row type variable usage in i-2-b- tests. 2021-03-29 [email protected] Fixes #1043. Remove static warning as an expected result 2021-03-29 [email protected] Fixes #1049: Correct expectation adjusted 2021-03-29 [email protected] Fixes #1048. Move tests to correct folder and change the description 2021-03-29 [email protected] Fixes #1046: Test adjusted to work with the generic metadata feature enabled. 2021-03-29 [email protected] Fixes #1047. Change expected result to not to fail on JavaScript configurations 2021-03-29 [email protected] Fixes #1044. Change expected result to not to fail on JavaScript configurations 2021-03-26 [email protected] Fixes #1029: Missing Issue tag added to the test. 2021-03-26 [email protected] Fixes #1042. Add check that produces different results for triple and double shifts 2021-03-26 [email protected] Fixes #1042. Fix built-in_types_t11.dart to expect correct results 2021-03-25 [email protected] Fixes #1019. Don't use type aliases in legacy libraries 2021-03-25 [email protected] Fixes #1039: Old-style aliases corrected. 2021-03-25 [email protected] Fixes #988. Expect static type warning in a right way 2021-03-24 [email protected] Issues #1029: Static expectation corrected. 2021-03-24 [email protected] Issues #1035: Issue tag for the bug 45443 added. 2021-03-24 [email protected] Merge branch 'master' of https://github.com/dart-lang/co19 2021-03-24 [email protected] #1023. Change SplayTreeMap and SplayTreeSet tests according to the new behavior 2021-03-23 [email protected] #1021. Remove expecting errors on web configurations for some negative numbers 2021-03-23 [email protected] Fixes #1034. Missed experimental flag added 2021-03-23 [email protected] #1033. Perform runtime check on big values for non-JavaScript configurations only 2021-03-23 [email protected] Issues #1029: co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02 corrected and does not expect a compile error now. Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try Change-Id: I5fae01c7b48aba502da04638430f4f6de79ac745 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194241 Reviewed-by: William Hesse <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by @seaneagan
The following corelib methods have a parameter typed Collection or List, which could be generalized to Iterable, since the parameter is merely iterated over:
Queue.addAll
List.addAll
Set.addAll
Set.containsAll
Set.intersection
Set.isSubsetOf
Set.removeAll
StringBuffer.addAll
Strings.concatAll
Strings.join
The text was updated successfully, but these errors were encountered: