Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust indentation of '}' when <enter> key pressed #3142

Closed
danrubel opened this issue May 18, 2012 · 4 comments
Closed

adjust indentation of '}' when <enter> key pressed #3142

danrubel opened this issue May 18, 2012 · 4 comments
Assignees
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Milestone

Comments

@danrubel
Copy link

floitsch: bad indentation.
given the following function:
foo() { return "bar"; }

Assume I want to transform this into:
foo() {
 return "bar";
}
Pressing <enter> after "{" works fine. The "return" is correctly indented.
But pressing <enter> after 'return "bar";' does not indent "}" correctly. It is at the same level as the "return".
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 7759
////////////////////////////////////////////////////////////////////////////////////
OS: Linux - amd64 (3.3.5-1-ARCH)
SDK installed = true
Dartium installed = true
AnalysisServer enabled = true
////////////////////////////////////////////////////////////////////////////////////

@stevemessick
Copy link
Contributor

Related to 1841 but different.


Added this to the M1 milestone.

@danrubel
Copy link
Author

danrubel commented Aug 3, 2012

Removed this from the M1 milestone.
Added this to the Later milestone.

@stevemessick
Copy link
Contributor

In the current framework, the editor doesn't know there won't be anything between the semicolon of the return statement and the closing brace. So it is actually working as it should because it is quite likely that there will be additional code entered at that point.


Added WontFix label.

@clayberg
Copy link

clayberg commented May 2, 2013

Removed this from the Later milestone.
Added this to the M5 milestone.

@danrubel danrubel added this to the M5 milestone May 2, 2013
@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug and removed resolution-wont_fix labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Sep 28, 2021
Changes:
```
> git log --format="%C(auto) %h %s" 15a46117da29cc572fba620241c83a2117cdae09..a817863ee93241ff36fce6856c6d12fd8fde0907
 a817863e Use pool for file reading (#3156)
 59237e29 Don't ask packageLister for availabe versions (#3151)
 f2f86c01 Fix analyze errors (#3148)
 39c9779c Environment credentials support (#3115)
 f0020823 Improved handling for authentication errors (#3120)
 1bb9f923 Migrate ignore.dart to null-safety (#3142)

```

Change-Id: I01d6637e3de8e523596394383393f5eda1a728c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214804
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Jonas Jensen <[email protected]>
copybara-service bot pushed a commit that referenced this issue Sep 7, 2022
…3 revisions)

https://dart.googlesource.com/dartdoc/+log/d732c8f4eda4..3bcfc1c2ba36

2022-09-07 [email protected] Deprecate linkedParamsNoMetadataOrNames (#3143)
2022-09-07 [email protected] Bump to 6.1.0 (#3141)
2022-09-07 [email protected] Bump to analyzer 4.7.0 (#3142)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: I148cbeb25af37331694a9c189bc58b7320eefc56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258060
Commit-Queue: DEPS Autoroller <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Devon Carew <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants