-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning not removed after renaming method #3156
Comments
Set owner to @scheglov. |
Can not reproduce. Initial source: class A { void main() { Has errors for duplicate "foo" declaration and warning for extra argument "i - 1" in recursive invocation. After renaming first "foo" to "foo2" no errors or warnings class A { cc @floitschG. |
Sorry, can't reproduce it (anymore?). |
Added AssumedStale label. |
This comment was originally written by [email protected] I'm still getting this with build 8370. |
Changes: ``` > git log --format="%C(auto) %h %s" 15a46117da29cc572fba620241c83a2117cdae09..a817863ee93241ff36fce6856c6d12fd8fde0907 a817863e Use pool for file reading (#3156) 59237e29 Don't ask packageLister for availabe versions (#3151) f2f86c01 Fix analyze errors (#3148) 39c9779c Environment credentials support (#3115) f0020823 Improved handling for authentication errors (#3120) 1bb9f923 Migrate ignore.dart to null-safety (#3142) ``` Change-Id: I01d6637e3de8e523596394383393f5eda1a728c9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214804 Reviewed-by: Jonas Jensen <[email protected]> Commit-Queue: Jonas Jensen <[email protected]>
…3 revisions) https://dart.googlesource.com/dartdoc/+log/691fa9640aae..62bc1503b285 2022-09-28 [email protected] Fix styles in inline search results (#3197) 2022-09-28 [email protected] Simplify some code in dartdoc_options.dart (#3156) 2022-09-28 [email protected] Prevent default when hitting enter (#3195) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-doc-dart-sdk Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I51527ab30a73a73de95f53715e83488562a54c71 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261445 Reviewed-by: Kevin Moore <[email protected]> Commit-Queue: Devon Carew <[email protected]>
If you know the Area- label, please set it and change status to Triaged.*
If you are reporting a problem in the Dart Editor, please open the Help ->
About Dart Editor dialog and add the Dart SDK version number to this
report. If you prefer, you can use the 'Send Feedback' button in the Dart
Editor to file a report that will contain this information and additional
context helpful for debugging the problem.
floitsch:
Had two methods with the same name:
resolve(Program node), and
resolve(String id, int index);
The latter had a recursive call: resolve(id, index - 1);
The editor correctly warned that something was wrong and underlined the calls to the second resolve because the signature was not correct. This included the recursive call.
After fixing the situation by renaming the first "resolve" function the error went away, but the recursive call still has yellow wiggly thingies below the arguments to "resolve".
Changing the line of the recursive call (just removing the ";" at the end of the line and readding it) made the yellow thing go away.
The text was updated successfully, but these errors were encountered: