Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate the invalid_runtime_check_with_js_interop_types lint out of experimental #56396

Closed
devoncarew opened this issue Aug 7, 2024 · 10 comments · Fixed by dart-lang/site-www#6033
Assignees
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.

Comments

@devoncarew
Copy link
Member

We're considering adding the invalid_runtime_check_with_js_interop_types lint to the package:lints lint set; we'd want to graduate the rule out of experimental before that.

cc @srujzs

@devoncarew devoncarew added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Aug 7, 2024
@srujzs
Copy link
Contributor

srujzs commented Aug 7, 2024

What does this entail? I thought it was connected to the LintRule, but LintRule.state is stable for this lint.

@devoncarew
Copy link
Member Author

I don't know; it shows as experimental here: https://dart.dev/tools/linter-rules/invalid_runtime_check_with_js_interop_types; perhaps there's something still to toggle, or perhaps it's been changed and there's some latency in updating that page.

@bwilkerson
Copy link
Member

@parlough

@kevmoo
Copy link
Member

kevmoo commented Aug 7, 2024

I think we need to update the website lints.

dart-lang/site-www#6025 this PR landed, but I think the JSON file is old!

@kevmoo
Copy link
Member

kevmoo commented Aug 7, 2024

I take that back. I just ran the update script against stable – and it all lines up. 🤷

@kevmoo
Copy link
Member

kevmoo commented Aug 7, 2024

@kevmoo
Copy link
Member

kevmoo commented Aug 7, 2024

is there a cache that's...old?
or something not rebuilt @parlough ?

@srujzs
Copy link
Contributor

srujzs commented Aug 7, 2024

Is this because of the 3.5.0-wip SDK dependency in the docs? It looks like the equivalent code in the SDK has been updated by @parlough yesterday (thanks!).

@devoncarew
Copy link
Member Author

I'd guess something similar; I don't think there's anything to update here wrt the impl. or state flag of the lint.

@parlough parlough self-assigned this Aug 7, 2024
@parlough
Copy link
Member

parlough commented Aug 7, 2024

I'm updating dart.dev in dart-lang/site-www#6033 which will surface it as stable and released in 3.5. I didn't do it right away as I had to account for lints no longer being part of 3 predefined categories. Sorry about the confusion!

parlough added a commit to dart-lang/site-www that referenced this issue Aug 7, 2024
Lints no longer are part of three specific groups, but now have
tags/groups (dart-lang/linter#1020). This PR
removes the expectation of the three groups so that the lints keep
rendering. It also updates the source data to the latest version with no
groups.

As part of the work in
#4499, we'll surface the new
categories/tags later on :)

Closes dart-lang/sdk#56396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants