Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for removal of lint groups #6033

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented Aug 7, 2024

Lints no longer are part of three specific groups, but now have tags/groups (dart-lang/linter#1020). This PR removes the expectation of the three groups so that the lints keep rendering. It also updates the source data to the latest version with no groups.

As part of the work in #4499, we'll surface the new categories/tags later on :)

Closes dart-lang/sdk#56396

Staged index page: https://dart-dev--pr6033-feat-lints-no-more-groups-b2yvk36h.web.app/tools/linter-rules

Staged js-interop lint page: https://dart-dev--pr6033-feat-lints-no-more-groups-b2yvk36h.web.app/tools/linter-rules/invalid_runtime_check_with_js_interop_types

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 62f24a8):

https://dart-dev--pr6033-feat-lints-no-more-groups-b2yvk36h.web.app

Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which SDK commit is this lints file from?

@parlough
Copy link
Member Author

parlough commented Aug 7, 2024

Which SDK commit is this lints file from?

I pulled it from main when I created this PR, so I believe dart-lang/sdk@47180c0. This includes my change from dart-lang/sdk@c50c194.

The reason the JS lint showed as unreleased was because before this change its since information had -wip in it.

@parlough parlough removed the request for review from domesticmouse August 7, 2024 21:31
@parlough parlough merged commit 345cf97 into main Aug 7, 2024
10 checks passed
@parlough parlough deleted the feat/lints-no-more-groups branch August 7, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graduate the invalid_runtime_check_with_js_interop_types lint out of experimental
3 participants