-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart_client buildbot failing #626
Comments
Added Triaged label. |
This comment was originally written by [email protected] Set owner to [email protected]. |
This comment was originally written by [email protected] Repro:
look into basicoptimizationstrategy.java (method maybeGetInlineableField and callees from there) as a starting point. Set owner to @jtmcdole. |
Missing scope variable in $bind3_2() of rtt.js Added Started label. |
r1903 Added Fixed label. |
Changes: ``` > git log --format="%C(auto) %h %s" 778174b..f35d1e1 https://dart.googlesource.com/http.git/+/f35d1e1 Require Dart 2.14, prepare to release v0.13.4 (#626) ``` Diff: https://dart.googlesource.com/http.git/+/778174bca2c13becd88ef3353309190b1e8b9479~..f35d1e1467092f6a5edb2abf7071c4a99e8c737a/ Change-Id: I302deb4e99d9c040e05473cd944b1eb64b619191 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215243 Reviewed-by: Nate Bosch <[email protected]> Commit-Queue: Nate Bosch <[email protected]> Auto-Submit: Kevin Moore <[email protected]>
…ions) https://dart.googlesource.com/protobuf/+log/408f69b98b2d..3105588b8e51 2022-06-15 [email protected] Remove unused function 2022-06-15 [email protected] Simplify PbList implementation, fix freezing (#626) 2022-06-15 [email protected] Remove frozen message modification handling (#643) 2022-06-15 [email protected] Bump version number for development, add changelog entry for #644 2022-06-15 [email protected] Remove ReadonlyMessageMixin (#644) 2022-06-15 [email protected] Release protobuf-2.1.0, protoc_plugin-20.0.1 (#677) 2022-06-14 [email protected] Specify `GeneratedMessage operator==` argument type (#675) 2022-06-14 [email protected] Add changes since the last protobuf release to CHANGELOG (#619) 2022-06-10 [email protected] Tweak consts.dart docs (#674) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-protobuf-dart-sdk Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dart Protobuf Support: https://github.com/dart-lang/protobuf/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: If0f2beb1f63ef9a7527abaa116d883ef0fd4b6c9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248620 Commit-Queue: Nate Bosch <[email protected]> Reviewed-by: Nate Bosch <[email protected]>
…, html, http, lints, markdown, matcher, mockito, path, protobuf, shelf, source_maps, source_span, sync_http, test, test_reflective_loader, tools, usage, vector_math, webdriver, webkit_inspection_protocol, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/5ac2ba1..1864048): 1864048 2023-05-03 Devon Carew added package topics to the pubspec file (#242) db229fb 2023-05-02 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#241) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/d5f8837..1b86d3c): 1b86d3c 2023-05-02 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#72) characters (https://github.com/dart-lang/characters/compare/b306414..2af6783): 2af6783 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#81) cli_util (https://github.com/dart-lang/cli_util/compare/6c318c2..7234f17): 7234f17 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#82) collection (https://github.com/dart-lang/collection/compare/9db854d..26e3e67): 26e3e67 2023-05-03 Lasse R.H. Nielsen Accept SDK version above 3.0. (#281) file (https://github.com/google/file.dart/compare/72a67c3..b905180): b905180 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#212) 8158a35 2023-05-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#218) html (https://github.com/dart-lang/html/compare/0438b26..5d87dc8): 5d87dc8 2023-05-03 Devon Carew added package topics to the pubspec file (#215) http (https://github.com/dart-lang/http/compare/877f134..f581ff7): f581ff7 2023-05-01 Nate Bosch Prepare to publish (#914) fa53651 2023-05-01 Brian Quinlan Document that RetryClient may consume a lot of memory (#915) lints (https://github.com/dart-lang/lints/compare/ba7d75e..17276ec): 17276ec 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#116) markdown (https://github.com/dart-lang/markdown/compare/82b050d..6db8fc1): 6db8fc1 2023-05-02 Jonas Finnemann Jensen Prepare 7.1.0 (#538) matcher (https://github.com/dart-lang/matcher/compare/7228c26..5890f2b): 5890f2b 2023-05-01 Nate Bosch Expand bound for `test_api` dependency (#219) mockito (https://github.com/dart-lang/mockito/compare/beb45ba..56173fa): 56173fa 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#626) path (https://github.com/dart-lang/path/compare/23e3319..1552cfd): 1552cfd 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#142) 82ddc60 2023-05-01 Jonathan fixed mistake in split method doc comment (#141) protobuf (https://github.com/dart-lang/protobuf/compare/b90a4c4..9d7cf0d): 9d7cf0d 2023-05-01 Kevin Moore Update Github Actions (#827) shelf (https://github.com/dart-lang/shelf/compare/9a792b4..79e3cee): 79e3cee 2023-05-03 Devon Carew add package topics for package:shelf_router_generator (#346) 25861e5 2023-05-03 Devon Carew add topics to the pubspec files (#345) source_maps (https://github.com/dart-lang/source_maps/compare/0a4b030..f0a8506): f0a8506 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#77) source_span (https://github.com/dart-lang/source_span/compare/905a167..69fa991): 69fa991 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#97) sync_http (https://github.com/dart-lang/sync_http/compare/660ad87..c3d6ad4): c3d6ad4 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#36) test (https://github.com/dart-lang/test/compare/b252463..9484592): 9484592a 2023-05-02 Nate Bosch Prepare to publish checks (#2005) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/a85a930..d1b763f): d1b763f 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#48) tools (https://github.com/dart-lang/tools/compare/516995e..b55f0d4): b55f0d4 2023-05-02 Elias Yishak `pddFlag` removal + tests for pdd restricted instance of `Analytics` (#86) usage (https://github.com/dart-lang/usage/compare/f97752f..929a4e3): 929a4e3 2023-05-02 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#193) vector_math (https://github.com/google/vector_math.dart/compare/7dec984..e3de8da): e3de8da 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#291) webdriver (https://github.com/google/webdriver.dart/compare/562aa06..d0f78d0): d0f78d0 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#273) 1ef3348 2023-05-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#275) webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/8401098..39a3c29): 39a3c29 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#102) 5555c53 2023-05-01 dependabot[bot] Bump nanasess/setup-chromedriver from 1.1.0 to 2.0.0 (#101) 9adce2a 2023-05-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#103) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/5f392a1..e05282b): e05282b 2023-05-02 Jonas Finnemann Jensen Prepare 2.1.1 release (#52) Change-Id: Iee7fd84d32ae37b76147d62c2268df19cf8db95b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300863 Reviewed-by: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
There are two tests failing in the optimized dart_client buildbot.
Path: client/samples/dartcombat/dartcombat_tests
--- stdout ---
Content-Type: text/plain
Running /mnt/data/b/build/slave/dart_client-linux-chromium-release/build/dart/client/tests/client/samples/dartcombat/dartcombat_tests.dart
Player 1 board:
Known of enemy's board:
ENEMY IS NOT READY0 <= 0 (0 + 0); 0
Player 2 board:
Known of enemy's board:
ENEMY IS NOT READY0 <= 0 (0 + 0); 0
EOF
CONSOLE MESSAGE: line 262: Uncaught TypeError: Cannot read property 'count' of undefined
Command: /mnt/data/b/build/slave/dart_client-linux-chromium-release/build/dart/client/tests/drt/DumpRenderTree --no-timeout "--dart-flags=--enable_asserts --enable_type_checks --ignore-unrecognized-flags" /mnt/data/b/build/slave/dart_client-linux-chromium-release/build/dart/client/out/Release_ia32/client_tests_client_samples_dartcombat_dartcombat_tests.dart.html
=== releaseia32 chromium client/samples/swarm/swarm_tests ===
Path: client/samples/swarm/swarm_tests
--- stdout ---
Content-Type: text/plain
Running /mnt/data/b/build/slave/dart_client-linux-chromium-release/build/dart/client/tests/client/samples/swarm/swarm_tests.dart
Swarm
Section 1
Section 2
Section 3
EOF
CONSOLE MESSAGE: line 560: Uncaught TypeError: Cannot read property 'count' of undefined
Command: /mnt/data/b/build/slave/dart_client-linux-chromium-release/build/dart/client/tests/drt/DumpRenderTree --no-timeout "--dart-flags=--enable_asserts --enable_type_checks --ignore-unrecognized-flags" /mnt/data/b/build/slave/dart_client-linux-chromium-release/build/dart/client/out/Release_ia32/client_tests_client_samples_swarm_swarm_tests.dart.html
===
=== 2 tests failed
An initial scan through buildbot logs shows the dart_combat failure happening intermittently at least as far back as r1624 (I can't definitively say that it wasn't happening before 1624). The failure in the test was intermittent, and became solidly red in the past few days.
The earliest build I see the swarm test failures is r1792.
When I run with --disable-type-optimizations, the failure doesn't reproduce for me (and the non-optimized buildbot has been green the whole time).
The text was updated successfully, but these errors were encountered: