Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings.join should take Iterable, rather than List<String> #666

Closed
DartBot opened this issue Dec 2, 2011 · 7 comments
Closed

Strings.join should take Iterable, rather than List<String> #666

DartBot opened this issue Dec 2, 2011 · 7 comments
Assignees
@lrhn
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Dec 2, 2011

This issue was originally filed by [email protected]

It seems like the join method on Strings should accept any Iterable, and call toString on an element if it's not a string.
Currently it only accepts List<String> which seems too restrictive.
@DartBot
Copy link
Author

DartBot commented Mar 20, 2012

This comment was originally written by [email protected]

Handing that bug to Josh.

Set owner to [email protected].

@sethladd
Copy link
Contributor

Added Library-Core label.

@DartBot
Copy link
Author

DartBot commented Jun 20, 2012

This comment was originally written by @seaneagan

issue #1059 is a more general version of this

@DartBot
Copy link
Author

DartBot commented Jun 20, 2012

This comment was originally written by @seaneagan

also see http://dartbug.com/324#c4 which suggests a Collection#join method

@sethladd
Copy link
Contributor

Removed the owner.
Removed Type-Defect, Library-Core labels.
Added Type-Enhancement label.

@floitschG
Copy link
Contributor

Fixed in experimental/lib_v2. Will close when landing in bleeding_edge.

Set owner to @lrhn.
Added Started label.

@floitschG
Copy link
Contributor

experimental has been merged.

Added Fixed label.

@DartBot DartBot added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Jan 7, 2013
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Jun 8, 2022
Roll Dart Protobuf Support from b149f801cf7a to 408f69b98b2d (9 revis…
258846f 
…ions)

https://dart.googlesource.com/protobuf/+log/b149f801cf7a..408f69b98b2d

2022-06-08 [email protected] Update documentation according to Effective Dart documentation guide (#664)
2022-06-02 [email protected] Move closures in proto3 deserializer to top-level (#668)
2022-06-02 [email protected] Refactor protobuf bench runners, update README: (#665)
2022-06-02 [email protected] Benchmarks: add proto3 ser/deser benchs, move common code to common.dart (#667)
2022-06-02 [email protected] Remove makeLongInt helper (#666)
2022-05-31 [email protected] Use `-O4` when compiling benchmarks. (#552)
2022-05-25 [email protected] Remove invalid check in `_FieldSet.writeFieldValue` (#660)
2022-05-20 [email protected] Refactor file locations, update READMEs (#657)
2022-05-19 [email protected] Remove trailing whitespace in protoc_plugin/README

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-protobuf-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Protobuf Support: https://github.com/dart-lang/protobuf/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: I0f1aa66ee6fe167f37443957234f4d0140828416
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247467
Reviewed-by: Devon Carew <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrhn lrhn

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sethladd @kevmoo @lrhn @floitschG @DartBot