Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internet Explorer tests time out on windows #1614

Closed
jakemac53 opened this issue Oct 21, 2021 · 6 comments · Fixed by #2114
Closed

Internet Explorer tests time out on windows #1614

jakemac53 opened this issue Oct 21, 2021 · 6 comments · Fixed by #2114

Comments

@jakemac53
Copy link
Contributor

No description provided.

jakemac53 added a commit that referenced this issue Oct 21, 2021
@jakemac53
fix parsing of windows file paths into a URI (#1611)
777bb15 
#1614
@gmpassos
Copy link
Contributor

FYI:
#1610

It seems that browser timeout is happening also in Linux and macOS.

@felangel felangel mentioned this issue Oct 23, 2021
Closed
@jakemac53
Copy link
Contributor Author

That is unrelated - this was happening before the bad release

@natebosch
Copy link
Member

@sigmundch - has dart2js dropped support for IE?

I wonder if we should just remove support for IE from the test runner. Would anyone even notice?

@natebosch natebosch mentioned this issue Oct 5, 2023
Draft
@gmpassos
Copy link
Contributor

gmpassos commented Oct 5, 2023 •
edited
Loading

I don’t think anyone should incentivize the use of IE, at least since 2016.

I hope this won’t break Edge support.

@jakemac53
Copy link
Contributor Author

We probably could just drop IE support. Edge should continue to work fine.

@natebosch natebosch mentioned this issue Oct 5, 2023
Merged
natebosch added a commit that referenced this issue Oct 5, 2023
@natebosch
Remove support for Internet Explorer
c0cc814 
Closes #1614

Use should be replaced by the edge browser.

It has been 2 years since we removed support for internet explorer in
dart2js. We have not been testing internet explorer integration, and it
may already be broken by dart2js changes.

Remove every reference to `ie` or internet explorer in the repo.

Treat this as non-breaking for `package:test` even though there is a
small risk of breaking some users still using internet explorer and it
happens to still be working.
@sigmundch
Copy link
Member

Agree, feel free to drop IE coverage. We dropped support for IE two years ago now, since Dart 2.14. See dart-lang/sdk#46545

natebosch added a commit that referenced this issue Dec 13, 2023
@natebosch
Remove support for Internet Explorer (#2114)
b3fb148 
Closes #1614

Use should be replaced by the edge browser.

It has been 2 years since we removed support for internet explorer in
dart2js. We have not been testing internet explorer integration, and it
may already be broken by dart2js changes.

Remove every reference to `ie` or internet explorer in the repo.

Treat this as non-breaking for `package:test` even though there is a
small risk of breaking some users still using internet explorer and it
happens to still be working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for Internet Explorer dart-lang/test
4 participants
@jakemac53 @sigmundch @gmpassos @natebosch