Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Internet Explorer #2114

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Remove support for Internet Explorer #2114

merged 4 commits into from
Dec 13, 2023

Conversation

natebosch
Copy link
Member

Closes #1614

Use should be replaced by the edge browser.

It has been 2 years since we removed support for internet explorer in
dart2js. We have not been testing internet explorer integration, and it
may already be broken by dart2js changes.

Remove every reference to ie or internet explorer in the repo.

Treat this as non-breaking for package:test even though there is a
small risk of breaking some users still using internet explorer and it
happens to still be working.

Closes #1614

Use should be replaced by the edge browser.

It has been 2 years since we removed support for internet explorer in
dart2js. We have not been testing internet explorer integration, and it
may already be broken by dart2js changes.

Remove every reference to `ie` or internet explorer in the repo.

Treat this as non-breaking for `package:test` even though there is a
small risk of breaking some users still using internet explorer and it
happens to still be working.
@natebosch
Copy link
Member Author

natebosch commented Oct 5, 2023

There is a usage of the Runtime constant in flutter engine.
https://github.com/flutter/engine/blob/0ff05464f42ffea289e0475d7fc0125b83c49f91/lib/web_ui/dev/edge.dart#L27

flutter/engine#46592 will move them to edge which is a better fit.

It's unfortunate to need a major version bump for this - I wonder if we can get away with eagerly fixing the flutter usage and then treating it as non-breaking. WDYT @jakemac53 ?

Or maybe we can drop the support in package:test and just leave the Runtime value around in test_api?

@jakemac53
Copy link
Contributor

I would be fine with leaving it around but just dropping support. Can we mark it deprecated?

@natebosch
Copy link
Member Author

Can we mark it deprecated?

Yes, after cleaning up flutter's usage.

@natebosch natebosch marked this pull request as ready for review December 13, 2023 01:14
@natebosch
Copy link
Member Author

Currently this is set up to land before the publish in #2156, but we shouldn't consider it a blocker for publishing.

@jakemac53
Copy link
Contributor

Lets go ahead and merge this prior to the publish

@natebosch natebosch merged commit b3fb148 into master Dec 13, 2023
35 checks passed
@natebosch natebosch deleted the drop-ie branch December 13, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internet Explorer tests time out on windows
2 participants