Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dwdsLaunch and dwdsAttach events #2418

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Apr 23, 2024

These events will allow us to distinguish between DWDS launches from:

  • headless test runner
  • DDR
  • Bolt

And will also allow us to distinguish between attaches to:

  • Cider
  • DevTools (embedded in Chrome DevTools)
  • DevTools (launched as a standalone app)

Work towards #2198

@elliette elliette merged commit 50bf268 into dart-lang:master Apr 24, 2024
47 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 25, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/1ae5b4c..d9e31ff):
  d9e31ff9  2024-04-22  Sam Rawlins  Extract Canonicalization from the ModelElement hierarchy (dart-lang/dartdoc#3753)

webdev (https://github.com/dart-lang/webdev/compare/d4f9f67..50bf268):
  50bf2687  2024-04-24  Elliott Brooks  Add `dwdsLaunch` and `dwdsAttach` events (dart-lang/webdev#2418)
  804eb5c5  2024-04-24  Elliott Brooks  Reset DWDS and WebDev after release (dart-lang/webdev#2419)
  988b03bf  2024-04-23  Elliott Brooks  Prepare webdev for release to version 3.5.0 (dart-lang/webdev#2417)
  68513c8f  2024-04-23  Elliott Brooks  Prepare DWDS for release to version 24.0.0 (dart-lang/webdev#2413)
  0b188169  2024-04-22  Elliott Brooks  Fix test timeouts related to weak null safety (dart-lang/webdev#2416)

Change-Id: Ie366c07cf46d7efb15d67322eac045e6a6bd7fe3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364522
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
@elliette elliette mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants