Move DWDS launch event #2423
Merged
Move DWDS launch event #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helin24
approved these changes
May 2, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 6, 2024
…browser_launcher, cli_util, clock, collection, convert, crypto, csslib, dartdoc, ecosystem, http, webdev, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/0370a67..09cba7f): 09cba7f 2024-05-03 Devon Carew blast_repo fixes (dart-archive/async#273) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/d396d3d..2fb4fbf): 2fb4fbf 2024-05-03 Devon Carew blast_repo fixes (dart-archive/bazel_worker#91) de7c44b 2024-05-02 dependabot[bot] Bump actions/checkout from 4.1.2 to 4.1.4 (dart-archive/bazel_worker#89) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/3a6ed5d..accc755): accc755 2024-05-03 Devon Carew blast_repo fixes (dart-archive/benchmark_harness#105) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/b353222..2cbd4a6): 2cbd4a6 2024-05-03 Devon Carew blast_repo fixes (dart-archive/boolean_selector#60) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/e5687b4..0dcf224): 0dcf224 2024-05-03 Devon Carew blast_repo fixes (dart-archive/browser_launcher#59) cli_util (https://github.com/dart-lang/cli_util/compare/5103eca..9fe3eeb): 9fe3eeb 2024-05-03 Devon Carew blast_repo fixes (dart-archive/cli_util#103) clock (https://github.com/dart-lang/clock/compare/c7e3875..80e70ac): 80e70ac 2024-05-03 Devon Carew blast_repo fixes (dart-archive/clock#64) collection (https://github.com/dart-lang/collection/compare/34b7269..4718398): 4718398 2024-05-03 Devon Carew blast_repo fixes (dart-archive/collection#340) convert (https://github.com/dart-lang/convert/compare/5da924b..056626e): 056626e 2024-05-03 Devon Carew blast_repo fixes (dart-archive/convert#105) crypto (https://github.com/dart-lang/crypto/compare/fc5e7c8..3f815ac): 3f815ac 2024-05-03 Devon Carew blast_repo fixes (dart-archive/crypto#170) csslib (https://github.com/dart-lang/csslib/compare/4ab68e4..141dd65): 141dd65 2024-05-03 Devon Carew blast_repo fixes (dart-archive/csslib#201) dartdoc (https://github.com/dart-lang/dartdoc/compare/d16bedc..6e9c1ea): 6e9c1eae 2024-05-02 Sam Rawlins Privatize ModelCommentReference.codeRef and .parsed (dart-lang/dartdoc#3764) ecosystem (https://github.com/dart-lang/ecosystem/compare/74942f6..9ce560b): 9ce560b 2024-05-03 dependabot[bot] Bump the dependencies group with 2 updates (dart-lang/ecosystem#262) bbb5c08 2024-05-03 Devon Carew update dependabot config; update related blast tweak (dart-lang/ecosystem#261) 678fe95 2024-05-02 dependabot[bot] Bump peter-evans/create-or-update-comment in the dependencies group (dart-lang/ecosystem#259) 9f6d4a9 2024-05-02 Devon Carew Update the dependabot config (dart-lang/ecosystem#258) http (https://github.com/dart-lang/http/compare/ec73b19..dd31e64): dd31e64 2024-05-02 Brian Quinlan Eagerly free resources on `CupertinoClient.close()` (dart-lang/http#1191) webdev (https://github.com/dart-lang/webdev/compare/b41ac34..c233e45): c233e453 2024-05-02 Elliott Brooks Move DWDS launch event (dart-lang/webdev#2423) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/fe2699d..c4629ad): c4629ad 2024-05-06 Jonas Finnemann Jensen A few more tests to reduce risk of regressions (dart-lang/yaml_edit#77) d15b44c 2024-05-06 Jonas Finnemann Jensen Consume until end of document if there is no newline when removing from (dart-lang/yaml_edit#76) Change-Id: I04956b5696ec7cfbeabdd4e0889c2e5934a6f48e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365483 Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2418
In google3, the buildSettings are not actually created until the app's entrypoint is loaded, which means that this was throwing a null-pointer exception.
Instead, we send the dwds launch event only once we have a debug connection with the app (which ensures that we have loaded the entrypoint).