Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump rust toolchain to nightly-2024-01-23 #14434

Merged
merged 1 commit into from
Jan 23, 2024
Merged

chore: bump rust toolchain to nightly-2024-01-23 #14434

merged 1 commit into from
Jan 23, 2024

Conversation

leiysky
Copy link
Collaborator

@leiysky leiysky commented Jan 23, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

The clippy check clippy::useless_asref is temporarily disabled because there is a bug rust-lang/rust-clippy#12148

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 23, 2024
@leiysky leiysky added the ci-benchmark Benchmark: run all test label Jan 23, 2024
@PsiACE
Copy link
Member

PsiACE commented Jan 23, 2024 •
edited
Loading

We need to update the rust-toolchain in the build tools first and merge it so that we can use available images for building and testing. like this #11711

@leiysky
Copy link
Collaborator Author

leiysky commented Jan 23, 2024

wait for #14436

@leiysky leiysky added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Jan 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14434-2d02e9e

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

cloud cloud

ClickBench Report

@leiysky leiysky added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Jan 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14434-5b94dce

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

cloud cloud

ClickBench Report

@leiysky leiysky added this pull request to the merge queue Jan 23, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 23, 2024
@BohuTANG BohuTANG merged commit 3acb8aa into datafuselabs:main Jan 23, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leiysky @PsiACE @BohuTANG