Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rename of VisibleDatasetFactory #387

Merged
merged 10 commits into from
Apr 4, 2024
Merged

Fix rename of VisibleDatasetFactory #387

merged 10 commits into from
Apr 4, 2024

Conversation

ThibaudDauce
Copy link
Contributor

maudetes
maudetes reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix! 🙏
I have minor comments on tests

udata_front/tests/views/test_organization.py Show resolved Hide resolved
udata_front/theme/gouvfr/templates/dataset/display.html Outdated Show resolved Hide resolved
maudetes
maudetes approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! 🙏

@ThibaudDauce ThibaudDauce merged commit ca06c43 into master Apr 4, 2024
7 checks passed
@ThibaudDauce ThibaudDauce deleted the fix_visible_datasets branch April 4, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

@nicolaskempf57 nicolaskempf57 nicolaskempf57 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaudDauce @nicolaskempf57 @maudetes