Visible datasets #2997
Merged
Visible datasets #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maudetes
reviewed
Mar 26, 2024
udata/tests/test_transfer.py
Outdated
| transfer = TransferFactory(owner=owner, | ||
| recipient=recipient, | ||
| subject=subject) | ||
|
|
||
| owner.count_datasets() |
There was a problem hiding this comment.
Why do we now need to call it explicitly here?
There was a problem hiding this comment.
The signal does not seem to be triggered
There was a problem hiding this comment.
It probably isn't triggered anymore due to the removal of
from udata.core.user.metrics import update_owner_metrics
from udata.core.organization.metrics import update_org_metrics
Could you add these instead with maybe a noqa comment and a small explanation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.