-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion): powerbi # Amazon Redshift lineage support #7562
Merged
jjoyce0510
merged 27 commits into
datahub-project:master
from
siddiquebagwan:master+powerbi-aws-redshift-lineage
Mar 20, 2023
Merged
feat(ingestion): powerbi # Amazon Redshift lineage support #7562
jjoyce0510
merged 27 commits into
datahub-project:master
from
siddiquebagwan:master+powerbi-aws-redshift-lineage
Mar 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dsiddique/datahub into master+fix-powerbi-bigquery-datasets
github-actions
bot
added
the
ingestion
PR or Issue related to the ingestion of metadata
label
Mar 13, 2023
…bi-aws-redshift-lineage
…bi-aws-redshift-lineage
…bi-aws-redshift-lineage
…bi-aws-redshift-lineage
jjoyce0510
reviewed
Mar 20, 2023
@@ -64,6 +70,21 @@ def get_full_table_names( | |||
def get_platform_pair(self) -> DataPlatformPair: | |||
pass | |||
|
|||
@staticmethod | |||
def get_db_name_from_second_argument(arg_list: Tree) -> Optional[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for extracting this
jjoyce0510
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM- Thanks for handling this!
iprentic
pushed a commit
to iprentic/datahub
that referenced
this pull request
Mar 20, 2023
…roject#7562) Co-authored-by: MohdSiddiqueBagwan <[email protected]> Co-authored-by: Harshal Sheth <[email protected]>
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 22, 2023
…roject#7562) Co-authored-by: MohdSiddiqueBagwan <[email protected]> Co-authored-by: Harshal Sheth <[email protected]>
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 22, 2023
…roject#7562) Co-authored-by: MohdSiddiqueBagwan <[email protected]> Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon Redshift table lineage support in PowerBI followed by #7541