Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove duplicate keys in docker-compose quickstart file #7878

Closed

Conversation

Gerrit-K
Copy link
Contributor

This partially reverts 1d33392

That commit duplicated some labels keys, resulting in errors when running datahub docker quickstart:

image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Apr 21, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Apr 21, 2023

@Gerrit-K for the error that you're seeing, what versions of docker and docker compose are you using?

Interestingly I haven't run into this issue before

hsheth2 added a commit to hsheth2/datahub that referenced this pull request Apr 21, 2023
Initially reported in datahub-project#7878. I'm also refactoring some of our code to be a bit more maintainable / readable moving forwards.
@hsheth2
Copy link
Collaborator

hsheth2 commented Apr 21, 2023

@Gerrit-K I've created #7886 to fix this more holistically. I'm going to close this one.

@hsheth2 hsheth2 closed this Apr 21, 2023
@Gerrit-K
Copy link
Contributor Author

Hey @hsheth2, sorry for the late reply.

@Gerrit-K for the error that you're seeing, what versions of docker and docker compose are you using?

Interestingly I haven't run into this issue before

Me neither 😕 the error and screenshot were provided from a third person, so unfortunately I can't give any specific details on the versions. All I can say is that I watched this person installing Docker Desktop (containing docker-compose) freshly on an M1 macbook. I recently did this setup myself, but I'm on an M2 mac, so that might make a difference.

Anyways, thanks for quickly taking a look and integrating the changes in your PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants