Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove duplicate labels from quickstart files #7886

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Apr 21, 2023

Initially reported in #7878. Looks like we fail to run with some versions of Docker / compose.

I'm also refactoring some of our code to be a bit more maintainable / readable moving forwards.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Initially reported in datahub-project#7878. I'm also refactoring some of our code to be a bit more maintainable / readable moving forwards.
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Apr 21, 2023
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with this code but looks good to me. Like the refactors

from collections.abc import Mapping

import click
import yaml
from dotenv import dotenv_values
from yaml import Loader

# Generates a merged docker-compose file with env variables inlined.
# Usage: python3 docker_compose_cli_gen.py ../docker-compose.yml ../docker-compose.override.yml ../docker-compose-gen.yml
COMPOSE_SPECS = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@hsheth2 hsheth2 merged commit 8f8c110 into datahub-project:master Apr 25, 2023
@hsheth2 hsheth2 deleted the quickstart-labels branch April 25, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants