Add ability to add batch of cells #797

jdbocarsly · 2024-07-11T03:39:41Z

Currently, the "batch add" feature only allows for adding samples. This PR adds the ability to also add cells, with a template option for positive electrode, electroylte, and negative electrode.

Functionality for adding a batch of cell and choosing electrodes
Figure out how to cleanly label positive electrode, electrolyte, and negative electrode fields
Rename "Add a batch of samples" -> "Add a batch of items"
Rename sample -> item in BatchCreateSampleModal.vue
Turn on taggable in the ItemSelect components in the batch sample modal
update e2e tests
add test(s)

Closes #396

codecov · 2024-07-11T03:44:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (95d5998) to head (c6dd527).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
- Coverage   67.26%   67.25%   -0.01%     
==========================================
  Files          62       62              
  Lines        3858     3857       -1     
==========================================
- Hits         2595     2594       -1     
  Misses       1263     1263

Files	Coverage Δ
pydatalab/pydatalab/routes/v0_1/items.py	`82.55% <100.00%> (-0.07%)`	⬇️

cypress · 2024-07-11T15:23:30Z

Test summary

1 • 0 • 0 • 0

Run details


Project	datalab
Status	Passed
Commit	`3d86110` ℹ️
Started	Jul 30, 2024 12:13 PM
Ended	Jul 30, 2024 12:13 PM
Duration	00:04 💡
OS	Linux Ubuntu -
Browser	Chrome 126

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

BenjaminCharmes

Perfect, everything works and looks nice. 👍
A small difference with "Add an item" is that Cell components are not written as optional in "Add batch of cells", If you want to add it.

jdbocarsly · 2024-07-14T20:24:19Z

A small difference with "Add an item" is that Cell components are not written as optional in "Add batch of cells", If you want to add it.

@BenjaminCharmes This is a good point, but I just tried adding in (optional) and it makes it a little bit messy, especially on small fields. I think that people will be able to figure it out pretty well, but if we get questions from users about this we can revisit in the future.

In general, I think this component probably needs to be redesigned to be more flexible/powerful at some point, and also mobile-friendly.

…gets rid of console warnings)

rename samples -> items in Samples.vue (code and gui) add ability to add cell constituents in the batch modal rename BatchCreateSampleModal.vue to BatchCreateItemModal.vue rename various instances of sample->item in the source code for BatchCreateItemModal.vue use placeholder to indicate poisitive electrode, negative electrode, and electrolyte fields when adding a batch of cells fix typo in BatchCreateItemModal

…properly add in the additional electrode/electrolyte components unless the cell already had a component already

…me.vue

ml-evs

Looks great, thanks @jdbocarsly! Will push an additional test to this PR for the Python change, but otherwise this is ready to go.

I'm going to test it on the demo server with some legacy data immediately after merging, and if all is good I'll make a release.

pydatalab/pydatalab/routes/v0_1/items.py

jdbocarsly changed the title ~~Add ability to batch cells~~ Add ability to add batch of cells Jul 11, 2024

jdbocarsly force-pushed the jdb/batch-cells branch from bceeac4 to d8fa5bd Compare July 11, 2024 03:40

datalab-org deleted a comment from cypress bot Jul 11, 2024

jdbocarsly force-pushed the jdb/batch-cells branch 2 times, most recently from 49d0da0 to 1137cd8 Compare July 12, 2024 00:09

jdbocarsly marked this pull request as ready for review July 12, 2024 00:09

jdbocarsly requested a review from ml-evs as a code owner July 12, 2024 00:09

jdbocarsly requested a review from BenjaminCharmes July 12, 2024 00:09

jdbocarsly added the webapp For issues/PRs pertaining to the web interface label Jul 12, 2024

BenjaminCharmes previously approved these changes Jul 12, 2024

View reviewed changes

jdbocarsly force-pushed the jdb/batch-cells branch from 1137cd8 to fc1f713 Compare July 14, 2024 20:13

jdbocarsly dismissed BenjaminCharmes’s stale review via c6dd527 July 14, 2024 20:22

jdbocarsly force-pushed the jdb/batch-cells branch from c6dd527 to 1319b45 Compare July 17, 2024 14:52

jdbocarsly force-pushed the jdb/batch-cells branch from 1319b45 to e729b6f Compare July 25, 2024 14:05

ml-evs force-pushed the jdb/batch-cells branch from 52709c0 to beb3a79 Compare July 30, 2024 08:59

jdbocarsly added 7 commits July 30, 2024 11:08

fix type of modelValue in ItemSelect.vue to allow Strings or Arrays (…

9a6bc0e

…gets rid of console warnings)

update cypress test with the next button name (sample->item)

0e04f8b

fix bug in create_sample where cells copied from other cells did not …

e73f7c1

…properly add in the additional electrode/electrolyte components unless the cell already had a component already

add e2e tests for batch cell creation

7230578

improve batch sample table column sizing

5eece01

set default name to empty string (instead of null) in formattedItemNa…

4230c11

…me.vue

ml-evs force-pushed the jdb/batch-cells branch from beb3a79 to 4230c11 Compare July 30, 2024 10:08

Rename component in Prime table

914b84d

ml-evs force-pushed the jdb/batch-cells branch from fea4db4 to 914b84d Compare July 30, 2024 11:24

ml-evs added the enhancement New feature or request label Jul 30, 2024

ml-evs previously approved these changes Jul 30, 2024

View reviewed changes

pydatalab/pydatalab/routes/v0_1/items.py Show resolved Hide resolved

ml-evs dismissed their stale review via 4bc9757 July 30, 2024 11:49

ml-evs force-pushed the jdb/batch-cells branch from 4bc9757 to 2e29bc3 Compare July 30, 2024 12:01

Add test case for copy cell bugfix

9ed5024

ml-evs force-pushed the jdb/batch-cells branch from 2e29bc3 to 9ed5024 Compare July 30, 2024 12:05

ml-evs merged commit 204eec6 into main Jul 30, 2024
8 checks passed

ml-evs deleted the jdb/batch-cells branch July 30, 2024 12:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to add batch of cells #797

Add ability to add batch of cells #797

jdbocarsly commented Jul 11, 2024 •

edited

Loading

codecov bot commented Jul 11, 2024 •

edited

Loading

cypress bot commented Jul 11, 2024 •

edited

Loading

BenjaminCharmes left a comment

jdbocarsly commented Jul 14, 2024 •

edited

Loading

ml-evs left a comment

Add ability to add batch of cells #797

Add ability to add batch of cells #797

Conversation

jdbocarsly commented Jul 11, 2024 • edited Loading

codecov bot commented Jul 11, 2024 • edited Loading

Codecov Report

cypress bot commented Jul 11, 2024 • edited Loading

Test summary

Run details

BenjaminCharmes left a comment

Choose a reason for hiding this comment

jdbocarsly commented Jul 14, 2024 • edited Loading

ml-evs left a comment

Choose a reason for hiding this comment

jdbocarsly commented Jul 11, 2024 •

edited

Loading

codecov bot commented Jul 11, 2024 •

edited

Loading

cypress bot commented Jul 11, 2024 •

edited

Loading

jdbocarsly commented Jul 14, 2024 •

edited

Loading