Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to add batch of cells #797

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Add ability to add batch of cells #797

merged 9 commits into from
Jul 30, 2024

Commits on Jul 30, 2024

  1. fix type of modelValue in ItemSelect.vue to allow Strings or Arrays (… 

    …gets rid of console warnings)
    @jdbocarsly @ml-evs
    jdbocarsly authored and ml-evs committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9a6bc0e View commit details
    Browse the repository at this point in the history

  2. initial progress towards allowing to add a batch of cells 

    rename samples -> items in Samples.vue (code and gui)

add ability to add cell constituents in the batch modal

rename BatchCreateSampleModal.vue to BatchCreateItemModal.vue

rename various instances of sample->item in the source code for BatchCreateItemModal.vue

use placeholder to indicate poisitive electrode, negative electrode, and electrolyte fields when adding a batch of cells

fix typo in BatchCreateItemModal
    @jdbocarsly @ml-evs
    jdbocarsly authored and ml-evs committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    75e3f57 View commit details
    Browse the repository at this point in the history

  3. update cypress test with the next button name (sample->item)

    @jdbocarsly @ml-evs
    jdbocarsly authored and ml-evs committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0e04f8b View commit details
    Browse the repository at this point in the history

  4. fix bug in create_sample where cells copied from other cells did not … 

    …properly add in the additional electrode/electrolyte components unless the cell already had a component already
    @jdbocarsly @ml-evs
    jdbocarsly authored and ml-evs committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e73f7c1 View commit details
    Browse the repository at this point in the history

  5. add e2e tests for batch cell creation

    @jdbocarsly @ml-evs
    jdbocarsly authored and ml-evs committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7230578 View commit details
    Browse the repository at this point in the history

  6. improve batch sample table column sizing

    @jdbocarsly @ml-evs
    jdbocarsly authored and ml-evs committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5eece01 View commit details
    Browse the repository at this point in the history

  7. set default name to empty string (instead of null) in formattedItemNa… 

    …me.vue
    @jdbocarsly @ml-evs
    jdbocarsly authored and ml-evs committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4230c11 View commit details
    Browse the repository at this point in the history

  8. Rename component in Prime table

    @ml-evs
    ml-evs committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    914b84d View commit details
    Browse the repository at this point in the history

  9. Add test case for copy cell bugfix

    @ml-evs
    ml-evs committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9ed5024 View commit details
    Browse the repository at this point in the history