Use dynamic version number from git tags in webapp #906
Conversation
BenjaminCharmes
force-pushed
the
bc/version-numbers
branch
from
1b4c9de
to
a546f1a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
=======================================
Coverage 68.22% 68.22%
=======================================
Files 62 62
Lines 3909 3909
=======================================
Hits 2667 2667
Misses 1242 1242 |
datalab
|
||||||||||||||||||||||||
| Project |
datalab
|
| Run status |
|
| Run duration | 06m 34s |
| Commit |
|
| Committer | Benjamin Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
396
|
|
I'd like the version to be entirely dynamic and not reliant on someone committing the new version, we might need to look around a bit for packages that let us do this a la setuptools-scm |
BenjaminCharmes
added
enhancement
ml-evs
force-pushed
the
bc/version-numbers
branch
from
c59529a
to
79b69e5
Compare
There was a problem hiding this comment.
I wasn't happy with any libraries or the functionality of npm version from-git (which assumes you want to commit the tag, and doesn't let you control many things), so I've instead pushed a little node script that grabs the git version and sets it during build via the VUE_APP_GIT_VERSION env var (which can also be used to override it in cases where the .git info is not available). This basically fits the approach we take for Python now too.
The only weirdness is that the version in package.json (0.0.0-git) should now basically be ignored, and is just used as a fallback when the version has not been set by any other source.
ml-evs
changed the title
ml-evs
added
the
build
* Extend version handling in About page * Version app dynamically via auxiliary node script --------- Co-authored-by: Matthew Evans <[email protected]>
Closes #713