Use git version inside app container build #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
the
build
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
=======================================
Coverage 68.34% 68.34%
=======================================
Files 62 62
Lines 3924 3924
=======================================
Hits 2682 2682
Misses 1242 1242 |
datalab
|
||||||||||||||||||||||||
| Project |
datalab
|
| Run status |
|
| Run duration | 06m 41s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
396
|
ml-evs
commented
Oct 15, 2024
BenjaminCharmes
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Pass git version into app container and allow it to be overwritten by .env * Tidying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up #906 by using the version in the docker build, where available. It also provides the ability to manually set the tag version (useful in cases where the docker build is running inside git worktrees, or submodules).