Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A.J. Stein's Week 32 Feedback for Model Review #52

Merged
merged 2 commits into from
Aug 12, 2022
Merged

A.J. Stein's Week 32 Feedback for Model Review #52

merged 2 commits into from
Aug 12, 2022

Conversation

aj-stein-nist
Copy link

Committer Notes

As requested, this is the last call phase for catalog, profile, and related modules. Circling back on this now.

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist changed the base branch from main to issue1066-metaschema-updates August 12, 2022 13:13
@aj-stein-nist aj-stein-nist force-pushed the issue1066-metaschema-updates-feedback-week32 branch from 2c30a04 to d05ed55 Compare August 12, 2022 13:15
@aj-stein-nist aj-stein-nist reopened this Aug 12, 2022
@aj-stein-nist aj-stein-nist force-pushed the issue1066-metaschema-updates-feedback-week32 branch from f605e77 to 412343f Compare August 12, 2022 13:58
aj-stein-nist
aj-stein-nist commented Aug 12, 2022
View reviewed changes
src/metaschema/oscal_metadata_metaschema.xml Show resolved Hide resolved
src/metaschema/oscal_metadata_metaschema.xml Outdated
</allowed-values>
<!--
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to discuss the feasibility and usefulness of this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was asked to convert this into an issue for future development, it is not seen as an immediate enhancement or fix to improve the maintenance of the current model in this area.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can only check for if the last-modified is >= the latest revision.

@aj-stein-nist aj-stein-nist force-pushed the issue1066-metaschema-updates-feedback-week32 branch from 412343f to d16ea9d Compare August 12, 2022 14:28
@aj-stein-nist aj-stein-nist force-pushed the issue1066-metaschema-updates-feedback-week32 branch from d16ea9d to 6da87a9 Compare August 12, 2022 15:32
@aj-stein-nist aj-stein-nist mentioned this pull request Aug 12, 2022
Closed
@aj-stein-nist aj-stein-nist marked this pull request as ready for review August 12, 2022 17:32
@david-waltermire david-waltermire merged commit 578a6e8 into david-waltermire:issue1066-metaschema-updates Aug 12, 2022
This was referenced Aug 12, 2022
Open
Open
david-waltermire added a commit that referenced this pull request Aug 19, 2022
@aj-stein-nist @david-waltermire
A.J. Stein's Week 32 Feedback for Model Review (#52)
3dabaef 
* AJ Stein's week 32 feedback for usnistgov#1331.

Co-authored-by: David Waltermire <[email protected]>
david-waltermire added a commit that referenced this pull request Aug 22, 2022
@aj-stein-nist @david-waltermire
A.J. Stein's Week 32 Feedback for Model Review (#52)
a306f10 
* AJ Stein's week 32 feedback for usnistgov#1331.

Co-authored-by: David Waltermire <[email protected]>
david-waltermire added a commit that referenced this pull request Aug 23, 2022
@aj-stein-nist @david-waltermire
A.J. Stein's Week 32 Feedback for Model Review (#52)
ca58532 
* AJ Stein's week 32 feedback for usnistgov#1331.

Co-authored-by: David Waltermire <[email protected]>
david-waltermire added a commit that referenced this pull request Aug 23, 2022
@aj-stein-nist @david-waltermire
A.J. Stein's Week 32 Feedback for Model Review (#52)
c7e73ee 
* AJ Stein's week 32 feedback for usnistgov#1331.

Co-authored-by: David Waltermire <[email protected]>
david-waltermire added a commit that referenced this pull request Sep 26, 2022
@aj-stein-nist @david-waltermire
A.J. Stein's Week 32 Feedback for Model Review (#52)
4b91b6e 
* AJ Stein's week 32 feedback for usnistgov#1331.

Co-authored-by: David Waltermire <[email protected]>
david-waltermire added a commit that referenced this pull request Sep 27, 2022
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (usnistgov#…
39477fd 
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
david-waltermire added a commit that referenced this pull request Oct 28, 2022
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (usnistgov#…
52b81c9 
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
david-waltermire added a commit that referenced this pull request Oct 31, 2022
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (usnistgov#…
6f775a4 
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
david-waltermire added a commit that referenced this pull request Jun 5, 2023
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (usnistgov#…
d1902c3 
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
david-waltermire added a commit that referenced this pull request Jun 5, 2024
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (usnistgov#…
988817c 
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire david-waltermire left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aj-stein-nist @david-waltermire