Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default for show_call_signatures to 2 #412

Closed

Conversation

blueyed
Copy link
Collaborator

@blueyed blueyed commented May 8, 2015

This appears to be less error-prone.

E.g. with things like indenting plugins (Vimjas/vim-python-pep8-indent#41).

This appears to be less error-prone.
@davidhalter
Copy link
Owner

Hmm true, I'm just not sure if it's what I want. I actually like the way of show_call_signatures = 1 more, because it's what most IDE's do. I get however that it's a bit buggy.

Since we don't have the same opinion about this, I would like to gather community votes. If a majority of people prefers show_call_signatures = 2, I would be willing to change. In the end it's just changing a default, so people could still have the other behavior.

@oblitum
Copy link

oblitum commented May 13, 2015

+1, even though less pretty.

@blueyed
Copy link
Collaborator Author

blueyed commented May 13, 2015

👎, because I like them also more (having tried the one in the command line for a while now).

@oblitum
Copy link

oblitum commented May 13, 2015

👎, because I like them also more (having tried the one in the command line for a while now).

heh, there should be a meme for this situation.

@davidhalter
Copy link
Owner

I'm closing this one now, doesn't seem to have generated a lot of interest.

@nicolas33
Copy link

I vote show_call_signatures = 3, open a temporary window.

@davidhalter
Copy link
Owner

Lol. Hell no. :)

@nicolas33
Copy link

Why not? That's how docstring preview works. I guess that extending this feature for signatures is not a crazy idea.

@davidhalter
Copy link
Owner

It would just add additional complexity. I already don't like specifying show_call_signatures = 2, because it's not a bool value. I believe in simple APIs, if possible.

The docstring preview already support call signatures. They are added there.

@nicolas33
Copy link

Well, I don't find that option = number is complex.

Perhaps I took the issue the bad way. Since the signature is in the docstring preview, a good alternative could be to delay the closing of the popup until the closing parenthesis:

whatever. # <-- time the preview pops up.
whatever.call(with, any=parameter) # <-- time the preview gets closed. 

This makes sense because the docstring can still be usefull while typing the parameters, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants