feat: add RayCluster.status.metadata field #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
| @@ -112,6 +112,8 @@ type RayClusterStatus struct { | |||
| LastUpdateTime *metav1.Time `json:"lastUpdateTime,omitempty"` | |||
| // Service Endpoints | |||
| Endpoints map[string]string `json:"endpoints,omitempty"` | |||
| // Metadata | |||
| Metadata map[string]string `json:"metadata,omitempty"` | |||
There was a problem hiding this comment.
Here I think it's not necessary for us to add some new spec for the crd, for the metadata we can just store then as some annotation in rayclusters object.
There was a problem hiding this comment.
I see. @Jeffwan, are you OK with the annotation approach?
davidxia
force-pushed
the
dxia/patch1
branch
3 times, most recently
from
ff2a978
to
fa79d31
Compare
as map[string]string. First entry will be head node IP.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as map[string]string. First entry will be head node IP.
Why are these changes needed?
Related issue number
Checks