Skip to content

Commit

Permalink
Flexibilize MarkupSafe pinned version (#5039)
Browse files Browse the repository at this point in the history
* Flexibilize MarkupSafe pinned version

The current `MarkupSafe` pinned version has been added in #4746 as a
temporary fix for #4745.

However, the current restrictive approach isn't compatible with other
libraries that could require an even older version of `MarkupSafe`, like
Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`.

To avoid that issue, we can allow a greater range of supported
`MarkupSafe` versions. Considering the direct dependency `dbt-core` has
is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is
`MarkupSafe>=0.23` [1].

This fix should be also backported this to `1.0.latest` for inclusion in
the next v1.0 patch.

[0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125
[1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
  • Loading branch information
adamantike authored Apr 13, 2022
1 parent cfe81e8 commit 5ff81c2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .changes/unreleased/Fixes-20220413-151735.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Fixes
body: Relax minimum supported version of MarkupSafe
time: 2022-04-13T15:17:35.055274145-03:00
custom:
Author: adamantike
Issue: "4745"
PR: "5039"
2 changes: 1 addition & 1 deletion core/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
],
install_requires=[
"Jinja2==2.11.3",
"MarkupSafe==2.0.1",
"MarkupSafe>=0.23,<2.1",
"agate>=1.6,<1.6.4",
"click>=7.0,<9",
"colorama>=0.3.9,<0.4.5",
Expand Down

0 comments on commit 5ff81c2

Please sign in to comment.