Flexibilize MarkupSafe pinned version #5039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `MarkupSafe` pinned version has been added in dbt-labs#4746 as a temporary fix for dbt-labs#4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
|
Not sure if a change like this one would require a changelog entry. Open to suggestions! |
|
@adamantike Thanks for your PR.. a changelog entry for this would be great! |
|
Thanks for the quick reply! So, to validate before adding it to the changelog, would this be applicable to be backported to In case it is, should I add the changelog entry for that here too, or do you take care of that when cherry-picking the change? |
|
@adamantike we changed our changelog system to changie so all you need to do is follow the instruction in the link and the actual |
|
Thanks, I have added the changelog entry after following the Regarding why we need to provide an upper bound, it's because of this discussion: pallets/jinja#1602. |
|
@adamantike Thanks for contributing!!! |
|
Thanks for the quick resolution! With this PR merged, is there a formal process to ask for this fix to be backported to |
VersusFacit
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in #4746 as a temporary fix for #4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
|
@adamantike Thanks again for the contribution! Our team will handle backporting your change! |
leahwicz
added
backport 1.0.latest
leahwicz
pushed a commit
that referenced
this pull request
Apr 18, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in #4746 as a temporary fix for #4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
leahwicz
pushed a commit
that referenced
this pull request
Apr 19, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in #4746 as a temporary fix for #4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
4 tasks
4 tasks
leahwicz
added a commit
that referenced
this pull request
Apr 19, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in #4746 as a temporary fix for #4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53 Co-authored-by: Michael Manganiello <[email protected]>
leahwicz
added a commit
that referenced
this pull request
May 9, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in #4746 as a temporary fix for #4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53 Co-authored-by: Michael Manganiello <[email protected]>
1 task
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
May 20, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in dbt-labs#4746 as a temporary fix for dbt-labs#4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
MarkupSafepinned version has been added in #4746 as a temporary fix for #4745.However, the current restrictive approach isn't compatible with other libraries that could require an even older version of
MarkupSafe, like Airflow2.2.2[0], which requiresmarkupsafe>=1.1.1, <2.0.To avoid that issue, we can allow a greater range of supported
MarkupSafeversions. Considering the direct dependencydbt-corehas isJinja2==2.11.3, we can use its pinning as the lower bound, which isMarkupSafe>=0.23[1].This fix should be also backported this to
1.0.latestfor inclusion in the next v1.0 patch.[0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125
[1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
Checklist