Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexibilize MarkupSafe pinned version #5039

Merged
merged 2 commits into from
Apr 13, 2022

Commits on Apr 12, 2022

  1. Flexibilize MarkupSafe pinned version

    The current `MarkupSafe` pinned version has been added in dbt-labs#4746 as a
    temporary fix for dbt-labs#4745.
    
    However, the current restrictive approach isn't compatible with other
    libraries that could require an even older version of `MarkupSafe`, like
    Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`.
    
    To avoid that issue, we can allow a greater range of supported
    `MarkupSafe` versions. Considering the direct dependency `dbt-core` has
    is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is
    `MarkupSafe>=0.23` [1].
    
    This fix should be also backported this to `1.0.latest` for inclusion in
    the next v1.0 patch.
    
    [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125
    [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
    adamantike committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    fc13d2d View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Add changelog entry

    adamantike committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    b79e5e2 View commit details
    Browse the repository at this point in the history