fix pip upgrade step in CI for windows #5320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
kwigley
force-pushed
the
kwigley/test-windows-ci
branch
from
a557a64
to
0bd05aa
Compare
gshank
force-pushed
the
kwigley/test-windows-ci
branch
from
e3bdce9
to
ada0601
Compare
leahwicz
reviewed
Jun 1, 2022
| @@ -9,7 +9,7 @@ endif | |||
| .PHONY: dev | |||
| dev: ## Installs dbt-* packages in develop mode along with development dependencies. | |||
| @\ | |||
| pip install -r dev-requirements.txt -r editable-requirements.txt && \ | |||
| pip install -r dev-requirements.txt -r editable-requirements.txt | |||
There was a problem hiding this comment.
@kwigley any reason why this isn't python -m pip?
There was a problem hiding this comment.
I added that because it fixes an error I introduced a week ago (dangling & ). It's not actually used by CI.
This was referenced Jun 1, 2022
6 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5321
Description
Fixes CI failures running integration tests in Windows.
Checklist
changie newto create a changelog entry