Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] fix pip upgrade step in CI for windows for 1.0.latest #5355

Merged
merged 2 commits into from
Jun 9, 2022
Merged

[Backport] fix pip upgrade step in CI for windows for 1.0.latest #5355

merged 2 commits into from
Jun 9, 2022
+33 −33

Conversation

leahwicz
Copy link
Contributor

@leahwicz leahwicz commented Jun 9, 2022

Description

We need to update to use python -m for 1.0.latest as well so that Windows tests can pass. We did this for main and 1.1.latest already so this is a manual backport (wasn't clean backport) #5320

Checklist

@leahwicz leahwicz added the Skip Changelog Skips GHA to check for changelog file label Jun 9, 2022
@cla-bot cla-bot bot added the cla:yes label Jun 9, 2022
McKnight-42
McKnight-42 approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leahwicz leahwicz added the test all run tests for all python versions + systems label Jun 9, 2022
@leahwicz leahwicz closed this Jun 9, 2022
@leahwicz leahwicz reopened this Jun 9, 2022
@leahwicz leahwicz closed this Jun 9, 2022
@leahwicz leahwicz reopened this Jun 9, 2022
@leahwicz leahwicz merged commit b33b143 into 1.0.latest Jun 9, 2022
@leahwicz leahwicz deleted the leahwicz/pip1.0 branch June 9, 2022 17:01
@aranke aranke mentioned this pull request May 20, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@kwigley kwigley Awaiting requested review from kwigley

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

@gshank gshank Awaiting requested review from gshank

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file test all run tests for all python versions + systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leahwicz @McKnight-42