Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pytz dependency #7077

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Conversation

sdebruyn
Copy link
Contributor

resolves #7075

Description

dbt-core uses pytz directly. The dependency on babel guaranteed pytz to be there until now, but that dependency was recently removed. Since dbt-core uses pytz directly (in tracking), it should explicitly add a dependency on it

Checklist

@sdebruyn sdebruyn requested a review from a team as a code owner February 28, 2023 12:03
@cla-bot cla-bot bot added the cla:yes label Feb 28, 2023
@jtcohen6
Copy link
Contributor

Thanks for the quick work @sdebruyn! We'll need to backport this for inclusion in patch releases of actively supported versions.

@jtcohen6 jtcohen6 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Feb 28, 2023
@sdebruyn
Copy link
Contributor Author

@jtcohen6 already on it :)

@jtcohen6
Copy link
Contributor

Amazing - thank you!

I think my US-based colleagues are still asleep. As soon as someone is online, let's get these reviewed & merged & patched & released :)

@sdebruyn
Copy link
Contributor Author

if you'd be wondering where I got the version constraint from, this is what Babel has so what dbt-core previously had implicitly

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look goods. Thanks for the quick work here!

@emmyoop emmyoop merged commit 8b79747 into dbt-labs:main Feb 28, 2023
@jcarpenter12
Copy link

Thanks for jumping on this so quickly, we spotted this issue this morning impacting some of our ci pipelines

@nssalian nssalian added backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch and removed backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch labels Mar 3, 2023
@nssalian nssalian mentioned this pull request Mar 3, 2023
6 tasks
acurtis-evi pushed a commit to acurtis-evi/dbt-core that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2225] [Bug] Suddenly getting ModuleNotFoundError: No module named 'pytz'
5 participants