Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "except" field in Star macro handles cross db column casing #397

Conversation

danieldiamond
Copy link
Contributor

@danieldiamond danieldiamond commented Aug 4, 2021

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have "dispatched" any new macro(s) so non-core adapters can also use them (e.g. the star() source)
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@danieldiamond danieldiamond force-pushed the danieldiamond/update-star-macro branch from 3da448c to aaac6a3 Compare August 4, 2021 11:26
@danieldiamond
Copy link
Contributor Author

@jtcohen6 failing integration tests appear to be unrelated to this PR. Tried pinning dbt_requirements in integration_tests project even though it inherits from root directory but didn't help. I think it's occurring in run_tests.sh but unable to trace.

Anyways hoping this PR can make it through. Let me know if any additional information is required.

Error encountered in /home/********/project/integration_tests/dbt_modules/dbt_utils
Running with dbt=0.21.0-b1
Encountered an error:
Runtime Error
  Failed to read package: Runtime Error
    This version of dbt is not supported with the 'dbt_utils' package.
      Installed version of dbt: =0.21.0-b1
      Required version of dbt for 'dbt_utils': ['>=0.20.0', '<0.21.0']
    Check the requirements for the 'dbt_utils' package, or run dbt again with --no-version-check

@jtcohen6
Copy link
Contributor

jtcohen6 commented Aug 4, 2021

@danieldiamond This is related to how we run dbt-utils integration tests with the latest prerelease version of dbt, and we just released v0.21.0-b1 yesterday. As it is, there aren't going to be any breaking changes to dbt-utils in v0.21, so we can bump the require-dbt-version boundary accordingly.

@danieldiamond
Copy link
Contributor Author

cc'ing @jtcohen6 @annafil unable to add reviewers but would like to see this get merged in if possible

@reidwil-jb
Copy link
Contributor

#403 If one of our PR's gets merged, we should close the other @danieldiamond

@danieldiamond
Copy link
Contributor Author

niiice @reidwil-jb didnt realize that col.column|lower not in except|lower mapping can apply to both str and list objects 🔥

@reidwil-jb
Copy link
Contributor

@danieldiamond yep! Two solutions to solve the same problem! Would love to have this merged asap as the capitalization has tripped me up multiple times 😄

@annafil annafil self-assigned this Aug 25, 2021
@jasnonaz
Copy link
Contributor

Hi @danieldiamond - thank you so much for contributing to dbt-utils! Given the duplicate PRs, we are going to close this and merge #403.

@jasnonaz jasnonaz closed this Aug 30, 2021
@danieldiamond danieldiamond deleted the danieldiamond/update-star-macro branch August 31, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants