-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR - lowercase except
values in star()
#403
Conversation
I recently ran into something similar when using |
@ttusing Makes sense - would you want to push the necessary changes to this PR? |
Hmm, it seems like this casing difficulty is likely to apply to every time columns are compared in Jinja. I wonder if the best way to fix this is to update all instances of column set comparisons. I'll move this discussion to the issue ticket and look over things a bit more. |
Hi Reid - thank you so much for the fantastic PR!! I'm going to remove the comment that's no longer relevant than get this merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work - thank you!!
I think there's a bug here. I just upgraded and have a column missing. Does Before, I think something like this was running for me: But now I think it may run as: I was going to spend some more time looking at this tomorrow before filing an issue and repro as I'm pretty new to Python and Jinja, but wanted to share now in case this already sounds like this is the issue. |
We're noticing this too. I've written it up here. |
Thanks for the heads up @wuservices @EPNickBosma Can you check out #418 and let me know if this fixes the error you are seeing? |
resolves #402
This is a:
master
dev/
branchdev/
branchDescription & motivation
This PR allows a user to put their
except
values in whatever case they want when calling them withindbt_utils.star()
{{ dbt_utils.star(from=ref('my_model', except=["col_a","col_b"])
=={{ dbt_utils.star(from=ref('my_model', except=["COL_A","Col_B"])
Checklist
star()
source)