Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to macro section #555

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Fix link to macro section #555

merged 1 commit into from
Apr 27, 2022

Conversation

clausherther
Copy link
Contributor

@clausherther clausherther commented Apr 20, 2022 •
edited
Loading

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is main
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

A couple of links are missing the -source suffix.

@clausherther
Fix link to macro section
1561200 
A couple of links are missing the `-source` suffix.
@clausherther
Copy link
Contributor Author

Actually, also just realized there does not seem to be a README section for listagg even though the macro exists?

@judahrand
Copy link
Contributor

judahrand commented Apr 21, 2022 •
edited
Loading

If this is merged #552 can be closed.

@dbeatty10
Copy link
Contributor

Actually, also just realized there does not seem to be a README section for listagg even though the macro exists?

Good catch, Claus! I just merged #560 which adds docs for listagg, and it will go out in the next release.

@dbeatty10 dbeatty10 changed the base branch from main to next/patch April 27, 2022 16:26
@dbeatty10 dbeatty10 self-requested a review April 27, 2022 17:13
dbeatty10
dbeatty10 approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @clausherther and @judahrand for updating this! 🌱

@dbeatty10 dbeatty10 merged commit 5ba47a6 into dbt-labs:next/patch Apr 27, 2022
This was referenced Apr 27, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clausherther @judahrand @dbeatty10