Maven #372
Maven #372
Conversation
Currently not building anything just setting up the build and Github action Using the target platform during the Maven build and build the css plug-in For de-jcup#371
The m2e is (afaik) the eclipse maven integration and very mature - you are more experienced here and I think this is a good option.
ASP is (just) now available at maven central - see de-jcup/asp#38 and/or |
There was a problem hiding this comment.
Hello Lars, thanx for contributing!
have some open questions etc. Please read my comments. At least the drop of gradle.yml is something that must postponed as long as the maven build does not provide test results from "normal" junit tests and the README still references the badge from gradle.yml
| uses: actions/setup-java@v2 | ||
| with: | ||
| distribution: 'adopt' | ||
| java-version: '11' |
There was a problem hiding this comment.
Hmm.. currently I provide even very old eclipse versions with the plugin and support normally min JDK8.
There was even an issue where a user wanted still support for eclipse photon... see #316
Do you think it's a good idea to go to SDK 11 here?
There was a problem hiding this comment.
Having no option to comment on the deleted gradle.yml workflow: As long as the build with maven does not work and "normal" tests are not run by maven as well I would keep the old gradle build - it's generated badges are used inside the README in the root folder as well - so the README must be changed after full maven support as well to use the correct github action badge.
So please revert the delete - this time.
There was a problem hiding this comment.
As we move this to a branch, we should IMHO still delete the gradle file if it fails the verfication. I test this.
There was a problem hiding this comment.
Java 11 is required by Tycho since a while. It still can build plug-ins using BREE smaller than Java 11.
| @@ -633,7 +633,7 @@ | |||
| <page | |||
| id="asciidoctoreditor.eclipse.preferences.AsciiDoctorEditorEnvironmentPreferencePage" | |||
| class="de.jcup.asciidoctoreditor.preferences.AsciiDoctorEditorEnvironmentPreferencePage" | |||
| name="Environmemt" | |||
| name="Environment" | |||
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>eclipse.asciidoctor.editor</groupId> | ||
| <artifactId>releng</artifactId> | ||
| <version>1.0.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Could you please change to 2.5.0-SNAPSHOT or 2.4.2-SNAPSHOT ? Current version is 2.4.1 on eclipse marketplace.
There was a problem hiding this comment.
Will do but IMHO this is not really important, as this pom file will not create artifacts.
| </pluginRepositories> | ||
|
|
||
| <properties> | ||
| <tycho.version>2.5.0-SNAPSHOT</tycho.version> |
There was a problem hiding this comment.
Ahem - is this another version (the plugin version) - I am a little bit confused. My comment before was about the versions, but maybe this was only the POM version and this one the tycho plugin version ...
Hmm.. to keep things simple I would normally prefer to keep both versions in sync, so it would be always clear which pom is for which eclipse plugin version...
What's your opinion?
There was a problem hiding this comment.
This is the Tycho version used for the build, so we should not have that in sync with the Gradle editor version
|
Lets move this to a new branch "Maven". We can work out the details here. |
This is a first step in the direction of Maven Tycho. We could also use the libraries directly with the PDE m2e integration. Is that ok?
Is asp-server-asciidoctorj-launcher-dist.jar available at Maven central?
Description Resource Path Location Type
Project 'asciidoctor-editor-plugin' is missing required library: 'lib/asp-server-asciidoctorj-launcher-dist.jar' asciidoctor-editor-plugin Build path Build Path Problem