fix: Avoid showing the bounding box when the scene is still loading assets #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5782731
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1a5e9104.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://fix-bounding-box-initial-loa.js-sdk-toolchain.pages.dev |
Test this pull request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
==========================================
+ Coverage 66.81% 67.13% +0.32%
==========================================
Files 524 529 +5
Lines 16542 16676 +134
Branches 2111 2132 +21
==========================================
+ Hits 11052 11196 +144
+ Misses 5155 5143 -12
- Partials 335 337 +2 ☔ View full report in Codecov by Sentry. |
cyaiox
commented
Feb 28, 2024
| @@ -244,22 +248,22 @@ async function validateEntityIsOutsideLayout(entity: EcsEntity) { | |||
|
|
|||
| function updateMeshBoundingBoxVisibility(entity: EcsEntity, mesh: BABYLON.AbstractMesh) { | |||
| const scene = mesh.getScene() | |||
| if (scene.isLoading) return | |||
There was a problem hiding this comment.
Condition added to avoid showing bounding boxes while the scene is still loading assets
cazala
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation to avoid showing meshes' bounding boxes when the scene is still loading out of the layout.
It also adds a new
SceneMetricsRPC and store to consume the scenemetrics | limits | entitiesOutOfBoundariesoutside the inspector, like from the builder.