Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid showing the bounding box when the scene is still loading assets #906

Merged
merged 10 commits into from
Feb 29, 2024

refactor: get scene nodes

5782731
Select commit
Loading
Failed to load commit list.
Merged

fix: Avoid showing the bounding box when the scene is still loading assets #906

refactor: get scene nodes
5782731
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Feb 28, 2024 in 0s

86.33% of diff hit (target 66.81%)

View this Pull Request on Codecov

86.33% of diff hit (target 66.81%)

Annotations

Check warning on line 205 in packages/@dcl/inspector/src/lib/babylon/decentraland/EcsEntity.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/@dcl/inspector/src/lib/babylon/decentraland/EcsEntity.ts#L204-L205 

Added lines #L204 - L205 were not covered by tests

Check warning on line 252 in packages/@dcl/inspector/src/lib/babylon/decentraland/EcsEntity.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/@dcl/inspector/src/lib/babylon/decentraland/EcsEntity.ts#L251-L252 

Added lines #L251 - L252 were not covered by tests

Check warning on line 257 in packages/@dcl/inspector/src/lib/babylon/decentraland/EcsEntity.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/@dcl/inspector/src/lib/babylon/decentraland/EcsEntity.ts#L257 

Added line #L257 was not covered by tests

Check warning on line 263 in packages/@dcl/inspector/src/lib/babylon/decentraland/EcsEntity.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/@dcl/inspector/src/lib/babylon/decentraland/EcsEntity.ts#L263 

Added line #L263 was not covered by tests

Check warning on line 34 in packages/@dcl/inspector/src/redux/scene-metrics/index.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/@dcl/inspector/src/redux/scene-metrics/index.ts#L34 

Added line #L34 was not covered by tests

Check warning on line 37 in packages/@dcl/inspector/src/redux/scene-metrics/index.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/@dcl/inspector/src/redux/scene-metrics/index.ts#L37 

Added line #L37 was not covered by tests

Check warning on line 41 in packages/@dcl/inspector/src/redux/scene-metrics/index.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/@dcl/inspector/src/redux/scene-metrics/index.ts#L40-L41 

Added lines #L40 - L41 were not covered by tests

Check warning on line 7 in packages/@dcl/inspector/src/redux/scene-metrics/types.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/@dcl/inspector/src/redux/scene-metrics/types.ts#L2-L7 

Added lines #L2 - L7 were not covered by tests

Check warning on line 35 in packages/@dcl/inspector/src/redux/store.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/@dcl/inspector/src/redux/store.ts#L35 

Added line #L35 was not covered by tests

Check warning on line 5 in packages/@dcl/inspector/src/tooling-entrypoint.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/@dcl/inspector/src/tooling-entrypoint.ts#L5 

Added line #L5 was not covered by tests
View more details on Codecov