Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce Store protocol (v2) #5259

Merged
merged 9 commits into from
Jul 7, 2023
Merged

feat: introduce Store protocol (v2) #5259

merged 9 commits into from
Jul 7, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jul 3, 2023 •
edited
Loading

Related Issues

Proposed Changes:

  • Introduces a Store protocol with the 4 methods specified in the original proposal
  • Adapts typing in Pipeline
  • Adds typing in tests

How did you test it?

  • Existing tests

Notes for the reviewer

Should we test Protocols, and if yes, how? In my opinion they don't need, but I''l wait for @silvanocerza's opinion.

Checklist

@github-actions github-actions bot added the type:documentation Improvements on the docs label Jul 3, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jul 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5483968559

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 44.711%
Files with Coverage Reduction New Missed Lines %
preview/pipeline.py 3 91.18%
Totals Coverage Status
Change from base Build 5476747209: 0.05%
Covered Lines: 10300
Relevant Lines: 23037
💛 - Coveralls

@ZanSara ZanSara marked this pull request as ready for review July 3, 2023 16:01
@ZanSara ZanSara requested a review from a team as a code owner July 3, 2023 16:01
@ZanSara ZanSara requested review from anakin87 and silvanocerza and removed request for a team and anakin87 July 3, 2023 16:01
@ZanSara ZanSara mentioned this pull request Jul 3, 2023
Merged
@ZanSara ZanSara requested a review from silvanocerza July 5, 2023 11:00
@ZanSara ZanSara merged commit f49bd3a into main Jul 7, 2023
@ZanSara ZanSara deleted the v2-docstore-protocol branch July 7, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZanSara @coveralls @silvanocerza