-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend pipeline.add_component
to support stores
#5261
Conversation
Pull Request Test Coverage Report for Build 5575173381
💛 - Coveralls |
Co-authored-by: Silvano Cerza <[email protected]>
Co-authored-by: Silvano Cerza <[email protected]>
""" | ||
|
||
_store: Optional[Store] = None | ||
supported_stores: List[Type[Store]] = [Store] # type: ignore # (see https://github.com/python/mypy/issues/4717) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must not be part of the public interface of a component.
supported_stores: List[Type[Store]] = [Store] # type: ignore # (see https://github.com/python/mypy/issues/4717) | |
_supported_stores: List[Type[Store]] = [Store] # type: ignore # (see https://github.com/python/mypy/issues/4717) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this to be public API since all components will need to set it explicitly. I'll leave it without the underscore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, I very much prefer if we force component creators to be explicit when defining which stores their component supports.
This reverts commit 53f624b.
Related Issues
Store
protocol (v2) #5259Proposed Changes:
StoreMixin
andMultiStoreMixin
.MemoryRetriever
to this new connection styleHow did you test it?
Notes for the reviewer
Let's focus on how the API feels like both on the pipeline side and on the component side.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.