Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to canals==0.7.0 #5647

Merged
merged 22 commits into from
Aug 29, 2023
Merged

chore: migrate to canals==0.7.0 #5647

merged 22 commits into from
Aug 29, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Aug 28, 2023 •
edited
Loading

Related Issues

Proposed Changes:

  • canals==0.7.0 introduces a new requirement for component: to_dict and from_dict
  • This PR upgrades all components to match this new requirement.

How did you test it?

Local tests run

Notes for the reviewer

n/a

Checklist

@ZanSara ZanSara requested a review from a team as a code owner August 28, 2023 16:28
@ZanSara ZanSara requested review from silvanocerza and removed request for a team August 28, 2023 16:28
@ZanSara ZanSara mentioned this pull request Aug 28, 2023
Merged
@ZanSara ZanSara requested a review from a team as a code owner August 28, 2023 16:39
@ZanSara ZanSara requested review from dfokina and removed request for a team August 28, 2023 16:39
This was referenced Aug 28, 2023
Merged
Merged
Merged
Merged
Merged
@ZanSara ZanSara changed the title choare: migrate to canals==0.7.0 chore: migrate to canals==0.7.0 Aug 29, 2023
This was referenced Aug 29, 2023
Closed
Merged
@ZanSara ZanSara mentioned this pull request Aug 29, 2023
Merged
@ZanSara
chore: serialization methods for FileExtensionClassifier (#5651)
3476ac1 
* serialization methods for FileExtensionClassifier

* Update test_file_classifier.py
@ZanSara ZanSara mentioned this pull request Aug 29, 2023
Merged
@coveralls
Copy link
Collaborator

coveralls commented Aug 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6012394791

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.05%) to 48.336%
Files with Coverage Reduction New Missed Lines %
preview/components/classifiers/file_classifier.py 1 94.44%
preview/components/embedders/sentence_transformers_document_embedder.py 1 97.44%
preview/components/embedders/sentence_transformers_text_embedder.py 1 96.55%
preview/components/writers/document_writer.py 6 0.0%
Totals Coverage Status
Change from base Build 6012207560: 0.05%
Covered Lines: 11506
Relevant Lines: 23804
💛 - Coveralls

ZanSara and others added 8 commits August 29, 2023 15:25
@ZanSara
chore: serialization methods for RemoteWhisperTranscriber (#5650)
731b0ff 
* serialization methods for RemoteWhisperTranscriber

* remove patches
@silvanocerza
Add default to_dict and from_dict in document stores built with facto…
7067f67 
…ry (#5674)
@ZanSara
fix tests (#5671)
a8e5df1
@ZanSara
chore: simplify serialization methods for MemoryDocumentStore (#5667)
ec65f7e 
* simplify serialization for MemoryDocumentStore

* remove redundant tests

* pylint
@ZanSara
chore: serialization methods for MemoryRetriever (#5663)
fa9e3f0 
* serialization method for MemoryRetriever

* more tests

* remove hash from default_document_store_to_dict

* remove diff in factory.py
@ZanSara
chore: serialization methods for DocumentWriter (#5661)
156d44c 
* serialization methods for DocumentWriter

* more tests

* use factory
@ZanSara
Merge branch 'main' into default-to-from-dict
80affa3
@ZanSara
black
358d696
@ZanSara ZanSara merged commit b1daa7c into main Aug 29, 2023
58 checks passed
@ZanSara ZanSara deleted the default-to-from-dict branch August 29, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:build/distribution topic:crawler topic:dependencies topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: port preview components to Canals 0.7.0
3 participants
@ZanSara @coveralls @silvanocerza