-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to canals==0.7.0
#5647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:dependencies
topic:build/distribution
type:documentation
Improvements on the docs
labels
Aug 28, 2023
This was referenced Aug 28, 2023
ZanSara
changed the title
choare: migrate to
chore: migrate to Aug 29, 2023
canals==0.7.0
canals==0.7.0
This was referenced Aug 29, 2023
Co-authored-by: Silvano Cerza <[email protected]>
* serialization methods for FileExtensionClassifier * Update test_file_classifier.py
…r` (#5652) * serialization methods for SentenceTransformersDocumentEmbedder * fix device management
Pull Request Test Coverage Report for Build 6012394791
💛 - Coveralls |
* serialization methods for RemoteWhisperTranscriber * remove patches
* simplify serialization for MemoryDocumentStore * remove redundant tests * pylint
* serialization method for MemoryRetriever * more tests * remove hash from default_document_store_to_dict * remove diff in factory.py
* serialization methods for DocumentWriter * more tests * use factory
silvanocerza
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic:build/distribution
topic:crawler
topic:dependencies
topic:tests
type:documentation
Improvements on the docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
canals==0.7.0
introduces a new requirement for component:to_dict
andfrom_dict
How did you test it?
Local tests run
Notes for the reviewer
n/a
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.